ges: timeline: Fix message leaks

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/5608>
This commit is contained in:
Philippe Normand 2023-11-01 15:11:41 +00:00 committed by GStreamer Marge Bot
parent 114ef64465
commit 101205d429

View file

@ -447,12 +447,13 @@ ges_timeline_handle_message (GstBin * bin, GstMessage * message)
if (GST_MESSAGE_TYPE (message) == GST_MESSAGE_ASYNC_START) { if (GST_MESSAGE_TYPE (message) == GST_MESSAGE_ASYNC_START) {
GST_INFO_OBJECT (timeline, "Dropping %" GST_PTR_FORMAT, message); GST_INFO_OBJECT (timeline, "Dropping %" GST_PTR_FORMAT, message);
gst_message_unref (message);
return; return;
} }
if (GST_MESSAGE_TYPE (message) == GST_MESSAGE_ASYNC_DONE) { if (GST_MESSAGE_TYPE (message) == GST_MESSAGE_ASYNC_DONE) {
GST_INFO_OBJECT (timeline, "Dropping %" GST_PTR_FORMAT, message); GST_INFO_OBJECT (timeline, "Dropping %" GST_PTR_FORMAT, message);
gst_message_unref (message);
return; return;
} }
@ -502,15 +503,15 @@ ges_timeline_handle_message (GstBin * bin, GstMessage * message)
GST_OBJECT_UNLOCK (timeline); GST_OBJECT_UNLOCK (timeline);
} }
gst_message_unref (message);
if (amessage) { if (amessage) {
gst_message_unref (message);
gst_element_post_message (GST_ELEMENT_CAST (bin), amessage); gst_element_post_message (GST_ELEMENT_CAST (bin), amessage);
return;
} }
return;
} }
forward: forward:
gst_element_post_message (GST_ELEMENT_CAST (bin), message); GST_BIN_CLASS (parent_class)->handle_message (bin, message);
} }
static GstStateChangeReturn static GstStateChangeReturn