tcp: Convert tcpserversink to new helpers.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-base/-/merge_requests/1105>
This commit is contained in:
Doug Nazar 2021-04-19 15:53:36 -04:00 committed by GStreamer Marge Bot
parent 9ad0566c37
commit 0fefbc932a

View file

@ -296,43 +296,24 @@ gst_tcp_server_sink_init_send (GstMultiHandleSink * parent)
{ {
GstTCPServerSink *this = GST_TCP_SERVER_SINK (parent); GstTCPServerSink *this = GST_TCP_SERVER_SINK (parent);
GError *err = NULL; GError *err = NULL;
GInetAddress *addr; GList *addrs;
GList *cur_addr;
GSocketAddress *saddr; GSocketAddress *saddr;
GResolver *resolver;
gint bound_port; gint bound_port;
/* look up name if we need to */ addrs =
addr = g_inet_address_new_from_string (this->host); tcp_get_addresses (GST_ELEMENT (this), this->host,
if (!addr) {
GList *results;
resolver = g_resolver_get_default ();
results =
g_resolver_lookup_by_name (resolver, this->host,
this->element.cancellable, &err); this->element.cancellable, &err);
if (!results) if (!addrs)
goto name_resolve; goto name_resolve;
addr = G_INET_ADDRESS (g_object_ref (results->data));
g_resolver_free_addresses (results); /* iterate over addresses until one works */
g_object_unref (resolver); cur_addr = addrs;
}
#ifndef GST_DISABLE_GST_DEBUG
{
gchar *ip = g_inet_address_to_string (addr);
GST_DEBUG_OBJECT (this, "IP address for host %s is %s", this->host, ip);
g_free (ip);
}
#endif
saddr = g_inet_socket_address_new (addr, this->server_port);
g_object_unref (addr);
/* create the server listener socket */
this->server_socket = this->server_socket =
g_socket_new (g_socket_address_get_family (saddr), G_SOCKET_TYPE_STREAM, tcp_create_socket (GST_ELEMENT (this), &cur_addr, this->server_port,
G_SOCKET_PROTOCOL_TCP, &err); &saddr, &err);
g_list_free_full (addrs, g_object_unref);
if (!this->server_socket) if (!this->server_socket)
goto no_socket; goto no_socket;
@ -387,19 +368,17 @@ no_socket:
GST_ELEMENT_ERROR (this, RESOURCE, OPEN_READ, (NULL), GST_ELEMENT_ERROR (this, RESOURCE, OPEN_READ, (NULL),
("Failed to create socket: %s", err->message)); ("Failed to create socket: %s", err->message));
g_clear_error (&err); g_clear_error (&err);
g_object_unref (saddr);
return FALSE; return FALSE;
} }
name_resolve: name_resolve:
{ {
if (g_error_matches (err, G_IO_ERROR, G_IO_ERROR_CANCELLED)) { if (g_error_matches (err, G_IO_ERROR, G_IO_ERROR_CANCELLED)) {
GST_DEBUG_OBJECT (this, "Cancelled name resolval"); GST_DEBUG_OBJECT (this, "Cancelled name resolution");
} else { } else {
GST_ELEMENT_ERROR (this, RESOURCE, OPEN_READ, (NULL), GST_ELEMENT_ERROR (this, RESOURCE, OPEN_READ, (NULL),
("Failed to resolve host '%s': %s", this->host, err->message)); ("Failed to resolve host '%s': %s", this->host, err->message));
} }
g_clear_error (&err); g_clear_error (&err);
g_object_unref (resolver);
return FALSE; return FALSE;
} }
bind_failed: bind_failed: