mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2024-11-10 03:19:40 +00:00
Code Issues 1 Projects Releases Wiki Activity

libs: standardize the FIXME comment

Browse source 
This is a trivial patch that makes homogeneous the FIXME tag in
comments.

For more info about these comment style:
http://wiki.c2.com/?FixmeComment
This commit is contained in:
Víctor Manuel Jáquez Leal 2017-05-26 11:10:34 +02:00
parent e66aaf166c
commit 0e31137dec
4 changed files with 25 additions and 21 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
gst-libs/gst/vaapi/gstvaapidecoder_h265.c
View file

@ -615,7 +615,7 @@ get_max_dec_frame_buffering (GstH265SPS * sps)
max_dec_frame_buffering = 16;
}
/* Fixme: Add limit check based on Annex A */
/* FIXME: Add limit check based on Annex A */
/* Assuming HighestTid as sps_max_sub_layers_minus1 */
return MAX (1,
@ -1134,7 +1134,7 @@ ensure_context (GstVaapiDecoderH265 * decoder, GstH265SPS * sps)
priv->pic_height_in_luma_samples = sps->pic_height_in_luma_samples;
}
priv->progressive_sequence = 1; /*Fixme */
priv->progressive_sequence = 1; /* FIXME */
gst_vaapi_decoder_set_interlaced (base_decoder, !priv->progressive_sequence);
gst_vaapi_decoder_set_pixel_aspect_ratio (base_decoder,
sps->vui_params.par_n, sps->vui_params.par_d);
@ -1297,7 +1297,7 @@ decode_current_picture (GstVaapiDecoderH265 * decoder)
}
priv->decoder_state = 0;
/*Fixme: Use SEI header values */
/* FIXME: Use SEI header values */
priv->pic_structure = GST_VAAPI_PICTURE_STRUCTURE_FRAME;
if (!picture)
@ -1465,8 +1465,8 @@ decode_sps (GstVaapiDecoderH265 * decoder, GstVaapiDecoderUnit * unit)
sps->max_latency_increase_plus1[sps->max_sub_layers_minus1] - 1;
/* Calculate WpOffsetHalfRangeC: (7-34)
* Fixme: We don't have parser API for sps_range_extension, so assuming
* high_precision_offsets_enabled_flag as zero */
* FIXME: We don't have parser API for sps_range_extension, so
* assuming high_precision_offsets_enabled_flag as zero */
bitdepthC = sps->bit_depth_chroma_minus8 + 8;
priv->WpOffsetHalfRangeC =
1 << (high_precision_offsets_enabled_flag ? (bitdepthC - 1) : 7);
@ -1698,7 +1698,7 @@ init_picture (GstVaapiDecoderH265 * decoder,
pi->nalu.type <= GST_H265_NAL_SLICE_CRA_NUT)
picture->RapPicFlag = TRUE;
/*Fixme: Use SEI header values */
/* FIXME: Use SEI header values */
base_picture->structure = GST_VAAPI_PICTURE_STRUCTURE_FRAME;
picture->structure = base_picture->structure;
@ -1917,7 +1917,7 @@ fill_picture (GstVaapiDecoderH265 * decoder, GstVaapiPictureH265 * picture)
pic_param->pps_tc_offset_div2 = pps->tc_offset_div2;
COPY_FIELD (pps, num_extra_slice_header_bits);
/*Fixme: Set correct value as mentioned in va_dec_hevc.h */
/* FIXME: Set correct value as mentioned in va_dec_hevc.h */
pic_param->st_rps_bits = 0;
return TRUE;
}
@ -2306,7 +2306,7 @@ fill_pred_weight_table (GstVaapiDecoderH265 * decoder,
if ((pps->weighted_pred_flag && GST_H265_IS_P_SLICE (slice_hdr)) ||
(pps->weighted_bipred_flag && GST_H265_IS_B_SLICE (slice_hdr))) {
/* Fixme: This should be done in parser apis */
/* FIXME: This should be done in parser apis */
memset (slice_param->delta_luma_weight_l0, 0,
sizeof (slice_param->delta_luma_weight_l0));
memset (slice_param->luma_offset_l0, 0,

2
gst-libs/gst/vaapi/gstvaapidecoder_mpeg4.c
View file

@ -573,7 +573,7 @@ decode_picture (GstVaapiDecoderMpeg4 * decoder, const guint8 * buf,
* | |
* nearest I/P/S in the past with vop_coded ==1 |
* nearest I/P/S in the future with any vop_coded
* fixme, it said that B frame shouldn't use backward reference frame
* FIXME: it said that B frame shouldn't use backward reference frame
* when backward reference frame coded is 0
*/
if (priv->is_svh) {

26
gst-libs/gst/vaapi/gstvaapiencoder_h265.c
View file

@ -671,7 +671,7 @@ bs_write_slice (GstBitWriter * bs,
/* first_slice_segment_in_pic_flag */
WRITE_UINT32 (bs, encoder->first_slice_segment_in_pic_flag, 1);
/* Fixme: For all IRAP pics */
/* FIXME: For all IRAP pics */
/* no_output_of_prior_pics_flag */
if (GST_VAAPI_ENC_PICTURE_IS_IDR (picture))
WRITE_UINT32 (bs, no_output_of_prior_pics_flag, 1);
@ -957,7 +957,8 @@ ensure_tier (GstVaapiEncoderH265 * encoder)
{
encoder->tier = GST_VAAPI_TIER_H265_MAIN;
/*Fixme: Derive proper tier based on upstream caps or limits, coding tools etc */
/* FIXME: Derive proper tier based on upstream caps or limits, coding
* tools etc */
return TRUE;
}
@ -976,8 +977,8 @@ ensure_level (GstVaapiEncoderH265 * encoder)
const GstVaapiH265LevelLimits *const limits = &limits_table[i];
if (PicSizeInSamplesY <= limits->MaxLumaPs)
break;
/* Fixme: Add more constraint checking:tier (extracted from caps), cpb size,
* bitrate, num_tile_columns and num_tile_rows */
/* FIXME: Add more constraint checking:tier (extracted from caps),
* cpb size, bitrate, num_tile_columns and num_tile_rows */
}
if (i == num_limits)
goto error_unsupported_level;
@ -1448,7 +1449,9 @@ fill_sequence (GstVaapiEncoderH265 * encoder, GstVaapiEncSequence * sequence)
seq_param->general_profile_idc = encoder->profile_idc;
seq_param->general_level_idc = encoder->level_idc;
seq_param->general_tier_flag = 0; /* Fixme: use the tier flag extracted from upstream caps or calcuted one */
seq_param->general_tier_flag = 0; /* FIXME: use the tier flag
* extracted from upstream
* caps or calcuted one */
seq_param->intra_period = GST_VAAPI_ENCODER_KEYFRAME_PERIOD (encoder);
seq_param->intra_idr_period = encoder->idr_period;
@ -1881,9 +1884,9 @@ ensure_bitrate (GstVaapiEncoderH265 * encoder)
switch (GST_VAAPI_ENCODER_RATE_CONTROL (encoder)) {
case GST_VAAPI_RATECONTROL_CBR:
if (!base_encoder->bitrate) {
/* Fixme: Provide better estimation */
/* FIXME: Provide better estimation */
/* Using a 1/6 compression ratio */
/* 12 bits per pixel fro yuv420 */
/* 12 bits per pixel for YUV420 */
guint64 factor = encoder->luma_width * encoder->luma_height * 12 / 6;
base_encoder->bitrate =
gst_util_uint64_scale (factor, GST_VAAPI_ENCODER_FPS_N (encoder),
@ -1951,7 +1954,7 @@ reset_properties (GstVaapiEncoderH265 * encoder)
if (encoder->idr_period > MAX_IDR_PERIOD)
encoder->idr_period = MAX_IDR_PERIOD;
/*Fixme: provide user control for idr_period ?? */
/* FIXME: provide user control for idr_period ?? */
encoder->idr_period = base_encoder->keyframe_period * 2;
if (encoder->min_qp > encoder->init_qp ||
@ -2318,8 +2321,9 @@ set_context_info (GstVaapiEncoder * base_encoder)
GstVideoInfo *const vip = GST_VAAPI_ENCODER_VIDEO_INFO (encoder);
const guint DEFAULT_SURFACES_COUNT = 3;
/* Fixme: Using only a rough approximation for bitstream headers..
* Fixme: Not taken into account: ScalingList, RefPicListModification, PredWeightTable */
/* FIXME: Using only a rough approximation for bitstream headers.
* Not taken into account: ScalingList, RefPicListModification,
* PredWeightTable */
/* Maximum sizes for common headers (in bits) */
enum
{
@ -2579,7 +2583,7 @@ gst_vaapi_encoder_h265_get_default_properties (void)
"Minimum QP", "Minimum quantizer value", 1, 51, 1,
G_PARAM_READWRITE | G_PARAM_STATIC_STRINGS));
/* Fixme: there seems to be issues with multi-slice encoding */
/* FIXME: there seems to be issues with multi-slice encoding */
/**
* GstVaapiEncoderH265:num-slices:
*

2
gst-libs/gst/vaapi/gstvaapiencoder_vp9.c
View file

@ -152,7 +152,7 @@ set_context_info (GstVaapiEncoder * base_encoder)
GstVideoInfo *const vip = GST_VAAPI_ENCODER_VIDEO_INFO (encoder);
const guint DEFAULT_SURFACES_COUNT = 2;
/*Fixme: Maximum sizes for common headers (in bytes) */
/* FIXME: Maximum sizes for common headers (in bytes) */
if (!ensure_hw_profile (encoder))
return GST_VAAPI_ENCODER_STATUS_ERROR_UNSUPPORTED_PROFILE;