mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2025-04-26 06:54:49 +00:00
Code Issues 1 Projects Releases Wiki Activity

validate: scenario: not need to use an atomic to handle dropped count

Browse source 
It's all handled from the same thread.
This commit is contained in:
Guillaume Desmottes 2019-02-08 14:36:56 +01:00
parent 78a8306955
commit 0e03b38cc2
1 changed files with 5 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
validate/gst/validate/gst-validate-scenario.c
View file

@ -828,20 +828,17 @@ static void
gst_validate_scenario_check_dropped (GstValidateScenario * scenario) gst_validate_scenario_check_dropped (GstValidateScenario * scenario)
{ {
GstValidateScenarioPrivate *priv = scenario->priv; GstValidateScenarioPrivate *priv = scenario->priv;
guint dropped;
dropped = g_atomic_int_get (&priv->dropped); if (priv->max_dropped == -1 || priv->dropped == -1)
if (priv->max_dropped == -1 || dropped == -1)
return; return;
GST_DEBUG_OBJECT (scenario, "Number of dropped buffers: %d (max allowed: %d)", GST_DEBUG_OBJECT (scenario, "Number of dropped buffers: %d (max allowed: %d)",
dropped, priv->max_dropped); priv->dropped, priv->max_dropped);
if (dropped > priv->max_dropped) { if (priv->dropped > priv->max_dropped) {
GST_VALIDATE_REPORT (scenario, CONFIG_TOO_MANY_BUFFERS_DROPPED, GST_VALIDATE_REPORT (scenario, CONFIG_TOO_MANY_BUFFERS_DROPPED,
"Too many buffers have been dropped: %d (max allowed: %d)", "Too many buffers have been dropped: %d (max allowed: %d)",
dropped, priv->max_dropped); priv->dropped, priv->max_dropped);
} }
} }
@ -3173,7 +3170,7 @@ message_cb (GstBus * bus, GstMessage * message, GstValidateScenario * scenario)
* will include the actual number of dropped buffers. */ * will include the actual number of dropped buffers. */
gst_message_parse_qos_stats (message, NULL, NULL, &dropped); gst_message_parse_qos_stats (message, NULL, NULL, &dropped);
if (dropped != -1) if (dropped != -1)
g_atomic_int_set (&priv->dropped, dropped); priv->dropped = dropped;
break; break;
} }