mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2024-12-18 14:26:43 +00:00
Code Issues 1 Projects Releases Wiki Activity

tests: qtdemux: Avoid using data beyond array and improve error msg

Browse source 
Makes it easier to debug the failures as well as prevents problems
reading out of bounds data.
This commit is contained in:
Thiago Santos 2018-05-28 10:59:14 -07:00
parent f72c7131ae
commit 0de143fa3e
1 changed files with 11 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
tests/check/elements/qtdemux.c
View file

@ -197,11 +197,19 @@ qtdemux_probe_for_reconfig (GstPad * pad, GstPadProbeInfo * info,
ReconfigTestData * data) ReconfigTestData * data)
{ {
GstEvent *event = GST_PAD_PROBE_INFO_EVENT (info); GstEvent *event = GST_PAD_PROBE_INFO_EVENT (info);
GstEventType expected = data->expected_events[data->step]; GstEventType expected;
if (data->step < data->total_step) {
expected = data->expected_events[data->step];
} else {
expected = GST_EVENT_UNKNOWN;
}
GST_DEBUG ("Got event %p %s", event, GST_EVENT_TYPE_NAME (event)); GST_DEBUG ("Got event %p %s", event, GST_EVENT_TYPE_NAME (event));
fail_unless (GST_EVENT_TYPE (event) == expected); fail_unless (GST_EVENT_TYPE (event) == expected,
"Received unexpected event: %s (expected: %s)",
GST_EVENT_TYPE_NAME (event), gst_event_type_get_name (expected));
data->step++; data->step++;
if (GST_EVENT_TYPE (event) == GST_EVENT_EOS && data->step < data->total_step) { if (GST_EVENT_TYPE (event) == GST_EVENT_EOS && data->step < data->total_step) {
@ -259,7 +267,7 @@ GST_START_TEST (test_qtdemux_duplicated_moov)
data.expected_events = expected; data.expected_events = expected;
data.expected_num_srcpad = 1; data.expected_num_srcpad = 1;
data.total_step = G_N_ELEMENTS (expected);; data.total_step = G_N_ELEMENTS (expected);
/* The goal of this test is to check that qtdemux can properly handle /* The goal of this test is to check that qtdemux can properly handle
* duplicated moov without redundant events and pad exposing * duplicated moov without redundant events and pad exposing