mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2024-11-20 16:51:10 +00:00
Code Issues 1 Projects Releases Wiki Activity

asset: plug a GTask leak

Browse source
This commit is contained in:
Thibault Saunier 2019-03-28 13:05:45 -03:00
parent 7f0810bae7
commit 0dcf78f3ec
1 changed files with 5 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
ges/ges-asset.c
View file

@ -1127,6 +1127,7 @@ ges_asset_request_async (GType extractable_type,
gchar *real_id; gchar *real_id;
GESAsset *asset; GESAsset *asset;
GError *error = NULL; GError *error = NULL;
GTask *task = NULL;
g_return_if_fail (g_type_is_a (extractable_type, G_TYPE_OBJECT)); g_return_if_fail (g_type_is_a (extractable_type, G_TYPE_OBJECT));
g_return_if_fail (g_type_is_a (extractable_type, GES_TYPE_EXTRACTABLE)); g_return_if_fail (g_type_is_a (extractable_type, GES_TYPE_EXTRACTABLE));
@ -1144,7 +1145,7 @@ ges_asset_request_async (GType extractable_type,
/* Check if we already have an asset for this ID */ /* Check if we already have an asset for this ID */
asset = ges_asset_cache_lookup (extractable_type, real_id); asset = ges_asset_cache_lookup (extractable_type, real_id);
if (asset) { if (asset) {
GTask *task = g_task_new (asset, NULL, callback, user_data); task = g_task_new (asset, NULL, callback, user_data);
/* In the case of proxied asset, we will loop until we find the /* In the case of proxied asset, we will loop until we find the
* last asset of the chain of proxied asset */ * last asset of the chain of proxied asset */
@ -1164,6 +1165,7 @@ ges_asset_request_async (GType extractable_type,
GST_DEBUG_OBJECT (asset, "Asset in cache and but not " GST_DEBUG_OBJECT (asset, "Asset in cache and but not "
"initialized, setting a new callback"); "initialized, setting a new callback");
ges_asset_cache_append_task (extractable_type, real_id, task); ges_asset_cache_append_task (extractable_type, real_id, task);
task = NULL;
goto done; goto done;
case ASSET_PROXIED:{ case ASSET_PROXIED:{
@ -1201,6 +1203,8 @@ ges_asset_request_async (GType extractable_type,
(extractable_type), G_PRIORITY_DEFAULT, cancellable, callback, user_data, (extractable_type), G_PRIORITY_DEFAULT, cancellable, callback, user_data,
"id", real_id, "extractable-type", extractable_type, NULL); "id", real_id, "extractable-type", extractable_type, NULL);
done: done:
if (task)
gst_object_unref (task);
if (real_id) if (real_id)
g_free (real_id); g_free (real_id);
} }