mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2024-11-23 10:11:08 +00:00
Code Issues 1 Projects Releases Wiki Activity

task: remove gst_task_set_priority()

Browse source 
It doesn't actually do anything.
This commit is contained in:
Tim-Philipp Müller 2012-04-08 21:17:14 +01:00
parent e434ac1d3e
commit 0cfc3cf8a2
4 changed files with 2 additions and 48 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
docs/gst/gstreamer-sections.txt
View file

@ -2650,7 +2650,6 @@ GST_TASK_WAIT
gst_task_new
gst_task_set_lock
gst_task_set_priority
gst_task_set_pool
gst_task_get_pool

44
gst/gsttask.c
View file

@ -96,9 +96,6 @@ struct _GstTaskPrivate
gpointer thr_user_data;
GDestroyNotify thr_notify;
gboolean prio_set;
GThreadPriority priority;
/* configured pool */
GstTaskPool *pool;
@ -190,7 +187,6 @@ gst_task_init (GstTask * task)
task->lock = NULL;
g_cond_init (&task->cond);
SET_TASK_STATE (task, GST_TASK_STOPPED);
task->priv->prio_set = FALSE;
/* use the default klass pool for this task, users can
* override this later */
@ -275,10 +271,6 @@ gst_task_func (GstTask * task)
if (G_UNLIKELY (lock == NULL))
goto no_lock;
task->thread = tself;
/* only update the priority when it was changed */
if (priv->prio_set) {
GST_INFO_OBJECT (task, "Thread priorities no longer have any effect");
}
GST_OBJECT_UNLOCK (task);
/* fire the enter_thread callback when we need to */
@ -440,42 +432,6 @@ is_running:
}
}
/**
* gst_task_set_priority:
* @task: a #GstTask
* @priority: a new priority for @task
*
* Changes the priority of @task to @priority.
*
* Note: try not to depend on task priorities.
*
* MT safe.
*
* Since: 0.10.24
*/
/* FIXME 0.11: remove gst_task_set_priority() */
void
gst_task_set_priority (GstTask * task, GThreadPriority priority)
{
GstTaskPrivate *priv;
GThread *thread;
g_return_if_fail (GST_IS_TASK (task));
priv = task->priv;
GST_OBJECT_LOCK (task);
priv->prio_set = TRUE;
priv->priority = priority;
thread = task->thread;
if (thread != NULL) {
/* if this task already has a thread, we can configure the priority right
* away, else we do that when we assign a thread to the task. */
GST_INFO_OBJECT (task, "Thread priorities no longer have any effect");
}
GST_OBJECT_UNLOCK (task);
}
/**
* gst_task_get_pool:
* @task: a #GstTask

1
gst/gsttask.h
View file

@ -177,7 +177,6 @@ GType gst_task_get_type (void);
GstTask* gst_task_new (GstTaskFunction func, gpointer data);
void gst_task_set_lock (GstTask *task, GRecMutex *mutex);
void gst_task_set_priority (GstTask *task, GThreadPriority priority);
GstTaskPool * gst_task_get_pool (GstTask *task);
void gst_task_set_pool (GstTask *task, GstTaskPool *pool);

4
tests/examples/streams/stream-status.c
View file

@ -83,8 +83,8 @@ sync_bus_handler (GstBus * bus, GstMessage * message, GstElement * bin)
break;
case GST_STREAM_STATUS_TYPE_ENTER:
if (task) {
g_message ("raising task priority for %p", task);
gst_task_set_priority (task, G_THREAD_PRIORITY_HIGH);
/* g_message ("raising task priority for %p", task); */
/* FIXME: do something here */
}
break;
case GST_STREAM_STATUS_TYPE_LEAVE: