mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2025-06-06 23:48:53 +00:00
Code Issues 1 Projects Releases Wiki Activity

pulsesink: don't error out if pa_stream_proplist_update() with new tags fails

Browse source 
Shouldn't really happen these days, but if it does, it's not really
a problem either.

https://bugzilla.gnome.org/show_bug.cgi?id=656068
This commit is contained in:
Tim-Philipp Müller 2013-01-19 13:27:48 +00:00
parent 066600c18b
commit 0c9b039c22
1 changed files with 5 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
ext/pulse/pulsesink.c
View file

@ -2700,11 +2700,12 @@ gst_pulsesink_change_props (GstPulseSink * psink, GstTagList * l)
if (pbuf == NULL || pbuf->stream == NULL) if (pbuf == NULL || pbuf->stream == NULL)
goto no_buffer; goto no_buffer;
if (!(o = pa_stream_proplist_update (pbuf->stream, PA_UPDATE_REPLACE,
pl, NULL, NULL)))
goto update_failed;
/* We're not interested if this operation failed or not */ /* We're not interested if this operation failed or not */
if (!(o = pa_stream_proplist_update (pbuf->stream, PA_UPDATE_REPLACE,
pl, NULL, NULL))) {
GST_DEBUG_OBJECT (psink, "pa_stream_proplist_update() failed");
}
unlock: unlock:
if (o) if (o)
@ -2725,13 +2726,6 @@ no_buffer:
GST_DEBUG_OBJECT (psink, "we have no ringbuffer"); GST_DEBUG_OBJECT (psink, "we have no ringbuffer");
goto unlock; goto unlock;
} }
update_failed:
{
GST_ELEMENT_ERROR (psink, RESOURCE, FAILED,
("pa_stream_proplist_update() failed: %s",
pa_strerror (pa_context_errno (pbuf->context))), (NULL));
goto unlock;
}
} }
static void static void