mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2024-12-24 17:20:36 +00:00
Code Issues 1 Projects Releases Wiki Activity

opusdec: do not assert on bad header, error out instead

Browse source
This commit is contained in:
Vincent Penquerc'h 2012-05-27 23:41:24 +01:00
parent f4848be30e
commit 0c55e0d98b
1 changed files with 9 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
ext/opus/gstopusdec.c
View file

@ -261,13 +261,19 @@ gst_opus_dec_parse_header (GstOpusDec * dec, GstBuffer * buf)
const GstAudioChannelPosition *posn = NULL; const GstAudioChannelPosition *posn = NULL;
GstMapInfo map; GstMapInfo map;
g_return_val_if_fail (gst_opus_header_is_id_header (buf), GST_FLOW_ERROR); if (!gst_opus_header_is_id_header (buf)) {
GST_ERROR_OBJECT (dec, "Header is not an Opus ID header");
return GST_FLOW_ERROR;
}
gst_buffer_map (buf, &map, GST_MAP_READ); gst_buffer_map (buf, &map, GST_MAP_READ);
data = map.data; data = map.data;
g_return_val_if_fail (dec->n_channels == 0 if (!(dec->n_channels == 0 || dec->n_channels == data[9])) {
|| dec->n_channels == data[9], GST_FLOW_ERROR); gst_buffer_unmap (buf, &map);
GST_ERROR_OBJECT (dec, "Opus ID header has invalid channels");
return GST_FLOW_ERROR;
}
dec->n_channels = data[9]; dec->n_channels = data[9];
dec->pre_skip = GST_READ_UINT16_LE (data + 10); dec->pre_skip = GST_READ_UINT16_LE (data + 10);