mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2024-10-05 02:02:26 +00:00
Code Issues 1 Projects Releases Wiki Activity

videoconvert: Compare y offset with height, not width, when testing for overlap

Browse source 
This could have prevented images showing that should have when the
source height is greater than its width.

When width exceeds height, as is common, it probably only caused a
miniscule amount of unnecessary work.  I haven't tested.
This commit is contained in:
Douglas Bagnall 2012-11-02 10:53:57 +13:00 committed by Sebastian Dröge
parent 5ac789408b
commit 0b898ab911
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
gst/videomixer/blend.c
View file

@ -273,7 +273,7 @@ blend_##format_name (GstVideoFrame * srcframe, gint xpos, gint ypos, \
ypos = 0; \
} \
/* If x or y offset are larger then the source it's outside of the picture */ \
if (xoffset > src_width || yoffset > src_width) { \
if (xoffset > src_width || yoffset > src_height) { \
return; \
} \
\
@ -518,7 +518,7 @@ blend_##format_name (GstVideoFrame * srcframe, gint xpos, gint ypos, \
ypos = 0; \
} \
/* If x or y offset are larger then the source it's outside of the picture */ \
if (xoffset > src_width || yoffset > src_width) { \
if (xoffset > src_width || yoffset > src_height) { \
return; \
} \
\