mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2024-11-14 05:12:09 +00:00
Code Issues 1 Projects Releases Wiki Activity

compositor: Consider the converter-config when deciding whether one pad obscures another

Browse source 
If the converter configuration is set to not fill any borders, or if the
border fill color is not full opaque, then the pad has to be handled
as potentially transparent and can't be considered to obscure another
one.

This prevents pads from being wrongly skipped and doing alpha-blending
with uninitialized memory.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-base/-/merge_requests/1172>
This commit is contained in:
Sebastian Dröge 2021-05-24 14:25:55 +03:00
parent 07fe3289bc
commit 0b6cd6862e
1 changed files with 17 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

17
gst/compositor/compositor.c
View file

@ -357,6 +357,9 @@ _pad_obscures_rectangle (GstVideoAggregator * vagg, GstVideoAggregatorPad * pad,
{
GstVideoRectangle pad_rect;
GstCompositorPad *cpad = GST_COMPOSITOR_PAD (pad);
GstStructure *converter_config = NULL;
gboolean fill_border = TRUE;
guint32 border_argb = 0xff000000;
/* No buffer to obscure the rectangle with */
if (!gst_video_aggregator_pad_has_current_buffer (pad))
@ -369,6 +372,20 @@ _pad_obscures_rectangle (GstVideoAggregator * vagg, GstVideoAggregatorPad * pad,
if (cpad->alpha != 1.0 || GST_VIDEO_INFO_HAS_ALPHA (&pad->info))
return FALSE;
/* If a converter-config is set and it is either configured to not fill any
* borders, or configured to use a non-opaque color, then we have to handle
* the pad as potentially containing transparency */
g_object_get (pad, "converter-config", &converter_config, NULL);
if (converter_config) {
gst_structure_get (converter_config, GST_VIDEO_CONVERTER_OPT_BORDER_ARGB,
G_TYPE_UINT, &border_argb, NULL);
gst_structure_get (converter_config, GST_VIDEO_CONVERTER_OPT_FILL_BORDER,
G_TYPE_BOOLEAN, &fill_border, NULL);
}
gst_clear_structure (&converter_config);
if (!fill_border || (border_argb & 0xff000000) != 0xff000000)
return FALSE;
pad_rect.x = cpad->xpos;
pad_rect.y = cpad->ypos;
/* Handle pixel and display aspect ratios to find the actual size */