mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2024-12-18 14:26:43 +00:00
Code Issues 1 Projects Releases Wiki Activity

Revert "oggdemux: Prevent seeks when _SCHEDULING_FLAG_SEQUENTIAL is set"

Browse source 
This reverts commit 76647f2710.

Avoiding pull mode activation is a feature regression, and
demuxers should always use pull mode where that is possible,
e.g. if there's an upstream queue2 with a ring buffer or
a download buffer.

This patch made reverse playback no longer possible over http.

If the goal is to minimise seeks, then that can still be done
by making the demuxer behave differently in pull mode if
the SEQUENTIAL flag is set. If there are bugs, like the demuxer
needlessly scanning the entire file on start-up in pull mode,
then those should be fixed instead.

https://bugzilla.gnome.org/show_bug.cgi?id=746010
This commit is contained in:
Tim-Philipp Müller 2015-05-20 10:22:48 +01:00
parent a5075a6ba8
commit 0a3b584aa0
1 changed files with 3 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
ext/ogg/gstoggdemux.c
View file

@ -4919,8 +4919,7 @@ static gboolean
gst_ogg_demux_sink_activate (GstPad * sinkpad, GstObject * parent)
{
GstQuery *query;
gboolean pull_mode = FALSE;
GstSchedulingFlags flags;
gboolean pull_mode;
query = gst_query_new_scheduling ();
@ -4929,13 +4928,8 @@ gst_ogg_demux_sink_activate (GstPad * sinkpad, GstObject * parent)
goto activate_push;
}
gst_query_parse_scheduling (query, &flags, NULL, NULL, NULL);
/* Don't use pull mode if sequential access is suggested */
if (gst_query_has_scheduling_mode (query, GST_PAD_MODE_PULL)) {
pull_mode = (flags & GST_SCHEDULING_FLAG_SEEKABLE) &&
!(flags & GST_SCHEDULING_FLAG_SEQUENTIAL);
}
pull_mode = gst_query_has_scheduling_mode_with_flags (query,
GST_PAD_MODE_PULL, GST_SCHEDULING_FLAG_SEEKABLE);
gst_query_unref (query);
if (!pull_mode)