mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2024-12-19 23:06:49 +00:00
Code Issues 1 Projects Releases Wiki Activity

omxvideoenc: validate cpb-size and initial-delay

Browse source 
cpb-size cannot be smaller than initial-delay.
This commit is contained in:
Guillaume Desmottes 2018-06-04 12:20:03 +02:00 committed by Guillaume Desmottes
parent aff131dcee
commit 09bc1d630f
1 changed files with 19 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

30
omx/gstomxvideoenc.c
View file

@ -612,20 +612,28 @@ set_zynqultrascaleplus_props (GstOMXVideoEnc * self)
} }
if (self->control_rate != OMX_Video_ControlRateDisable) { if (self->control_rate != OMX_Video_ControlRateDisable) {
OMX_ALG_VIDEO_PARAM_CODED_PICTURE_BUFFER cpb; if (self->cpb_size < self->initial_delay) {
GST_ERROR_OBJECT (self,
"cpb-size (%d) cannot be smaller than initial-delay (%d)",
self->cpb_size, self->initial_delay);
g_critical ("cpb-size (%d) cannot be smaller than initial-delay (%d)",
self->cpb_size, self->initial_delay);
} else {
OMX_ALG_VIDEO_PARAM_CODED_PICTURE_BUFFER cpb;
GST_OMX_INIT_STRUCT (&cpb); GST_OMX_INIT_STRUCT (&cpb);
cpb.nPortIndex = self->enc_out_port->index; cpb.nPortIndex = self->enc_out_port->index;
cpb.nCodedPictureBufferSize = self->cpb_size; cpb.nCodedPictureBufferSize = self->cpb_size;
cpb.nInitialRemovalDelay = self->initial_delay; cpb.nInitialRemovalDelay = self->initial_delay;
GST_DEBUG_OBJECT (self, "setting cpb size to %d and initial delay to %d", GST_DEBUG_OBJECT (self, "setting cpb size to %d and initial delay to %d",
self->cpb_size, self->initial_delay); self->cpb_size, self->initial_delay);
err = err =
gst_omx_component_set_parameter (self->enc, gst_omx_component_set_parameter (self->enc,
(OMX_INDEXTYPE) OMX_ALG_IndexParamVideoCodedPictureBuffer, &cpb); (OMX_INDEXTYPE) OMX_ALG_IndexParamVideoCodedPictureBuffer, &cpb);
CHECK_ERR ("cpb size & initial delay"); CHECK_ERR ("cpb size & initial delay");
}
} }
{ {