mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2024-12-23 08:46:40 +00:00
Code Issues 1 Projects Releases Wiki Activity

gst: don't use volatile to mean atomic

Browse source 
volatile is not sufficient to provide atomic guarantees and real atomics
should be used instead.  GCC 11 has started warning about using volatile
with atomic operations.

https://gitlab.gnome.org/GNOME/glib/-/merge_requests/1719

Discovered in https://gitlab.freedesktop.org/gstreamer/gst-plugins-good/-/issues/868

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-editing-services/-/merge_requests/234>
This commit is contained in:
Matthew Waters 2021-03-19 17:21:01 +11:00
parent edf58d30e6
commit 083ae2b8ed
4 changed files with 5 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
ges/ges-smart-video-mixer.c
View file

@ -124,7 +124,7 @@ static GstStaticPadTemplate sink_template = GST_STATIC_PAD_TEMPLATE ("sink_%u",
typedef struct _PadInfos
{
volatile gint refcount;
gint refcount;
GESSmartMixer *self;
GstPad *mixer_pad;
@ -149,7 +149,7 @@ static PadInfos *
pad_infos_new (void)
{
PadInfos *info = g_new0 (PadInfos, 1);
info->refcount = 1;
g_atomic_int_set (&info->refcount, 1);
return info;
}

2
ges/gstframepositioner.c
View file

@ -624,7 +624,7 @@ gst_frame_positioner_get_property (GObject * object, guint property_id,
GType
gst_frame_positioner_meta_api_get_type (void)
{
static volatile GType type;
static GType type;
static const gchar *tags[] = { "video", NULL };
if (g_once_init_enter (&type)) {

2
plugins/nle/nlecomposition.c
View file

@ -195,7 +195,7 @@ struct _NleCompositionPrivate
gint seqnum_to_restart_task;
gboolean waiting_serialized_query_or_buffer;
GstEvent *stack_initialization_seek;
volatile gboolean stack_initialization_seek_sent;
gboolean stack_initialization_seek_sent;
gboolean tearing_down_stack;
gboolean suppress_child_error;

2
plugins/nle/nleobject.c
View file

@ -835,7 +835,7 @@ nle_object_reset (NleObject * object)
GType
nle_object_get_type (void)
{
static volatile gsize type = 0;
static gsize type = 0;
if (g_once_init_enter (&type)) {
GType _type;