pad: simplify gst_pad_link_get_name() and fix Since marker

Has added benefit that compiler might warn if more values
are added to the enum.
This commit is contained in:
Tim-Philipp Müller 2014-03-11 21:44:39 +00:00
parent 4a38acaa10
commit 075cc42f88

View file

@ -259,17 +259,28 @@ gst_flow_to_quark (GstFlowReturn ret)
* *
* Returns: a static string with the name of the pad-link return. * Returns: a static string with the name of the pad-link return.
* *
* Since: 1.3.1 * Since: 1.4
*/ */
const gchar * const gchar *
gst_pad_link_get_name (GstPadLinkReturn ret) gst_pad_link_get_name (GstPadLinkReturn ret)
{ {
static const gchar *names[(-(GST_PAD_LINK_REFUSED)) + 1] = { switch (ret) {
"ok", "wrong hierarchy", "was linked", "wrong direction", "no format", case GST_PAD_LINK_OK:
"incompatible scheduling", "refused" return "ok";
}; case GST_PAD_LINK_WRONG_HIERARCHY:
ret = CLAMP (ret, GST_PAD_LINK_REFUSED, GST_PAD_LINK_OK); return "wrong hierarchy";
return names[-ret]; case GST_PAD_LINK_WAS_LINKED:
return "was linked";
case GST_PAD_LINK_WRONG_DIRECTION:
return "wrong direction";
case GST_PAD_LINK_NOFORMAT:
return "no common format";
case GST_PAD_LINK_NOSCHED:
return "incompatible scheduling";
case GST_PAD_LINK_REFUSED:
return "refused";
}
g_return_val_if_reached ("unknown");
} }
#define _do_init \ #define _do_init \