mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2024-10-02 08:42:32 +00:00
Code Issues 1 Projects Releases Wiki Activity

ximagesrc: Fix ximage leaks when buffer has more then one ximage

Browse source 
From time to time, when the image_pool list has more then 1 element
and I suppose at start, all but 1 pooled ximage are leaked. This is
due to broken algorithm in gst_ximagesink_src_ximage_get(). There was
also a risk of use after free for the case where the ximage size has
changed.

https://bugzilla.gnome.org/show_bug.cgi?id=728502
This commit is contained in:
Nicolas Dufresne 2014-05-20 17:37:49 -04:00
parent e5854c149b
commit 0746bca190
1 changed files with 7 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
sys/ximage/gstximagesrc.c
View file

@ -460,13 +460,15 @@ gst_ximage_src_ximage_get (GstXImageSrc * ximagesrc)
meta = GST_META_XIMAGE_GET (ximage);
if ((meta->width != ximagesrc->width) ||
(meta->height != ximagesrc->height)) {
gst_ximage_buffer_free (ximage);
}
ximagesrc->buffer_pool = g_slist_delete_link (ximagesrc->buffer_pool,
ximagesrc->buffer_pool);
if ((meta->width == ximagesrc->width) ||
(meta->height == ximagesrc->height))
break;
gst_ximage_buffer_free (ximage);
ximage = NULL;
}
g_mutex_unlock (&ximagesrc->pool_lock);