mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2025-04-26 04:56:14 +00:00
Code Issues 1 Projects Releases Wiki Activity

imagefreeze: Correctly answer the LATENCY query

Browse source 
We never run as a live element, even if upstream is live, and never
output any buffers with latency but immediately generate buffers as
fast as we can according to the negotiated framerate.

Passing the query upstream would proxy whatever mode of operation
upstream has, which has nothing to do with how we produce buffers.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-good/-/merge_requests/653>
This commit is contained in:
Sebastian Dröge 2020-06-28 22:26:23 +03:00
parent ca61a76987
commit 06b29a4aef
1 changed files with 4 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
gst/imagefreeze/gstimagefreeze.c
View file

@ -536,11 +536,10 @@ gst_image_freeze_src_query (GstPad * pad, GstObject * parent, GstQuery * query)
break; break;
} }
case GST_QUERY_LATENCY: case GST_QUERY_LATENCY:
/* This will only return an accurate latency for the first buffer since /* We never run as a live element, even if upstream is live, and never
* all further buffers outputted by us are just copies of that one, and * output any buffers with latency but immediately generate buffers as
* the latency is 0 in that case. However, latency changes are not * fast as we can according to the negotiated framerate */
* straightforward, so let's do the conservative fix for now. */ gst_query_set_latency (query, FALSE, 0, GST_CLOCK_TIME_NONE);
ret = gst_pad_query_default (pad, parent, query);
break; break;
default: default:
ret = FALSE; ret = FALSE;