mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2024-11-10 03:19:40 +00:00
Code Issues 1 Projects Releases Wiki Activity

libs: decoder: h265: check for null

Browse source 
Coverity scan bug:

Dereference after null check: Either the check against null is
unnecessary, or there may be a null pointer dereference.

While looking for hte lowest poc, according to rest of the code, the
picture in the dbp (decoded picture buffer) might be NULL, thus we
could check for a NULL picture before assigned as found.

Also, split a comma operator because it is considered as a bad
practice because it possible side effects.
This commit is contained in:
Víctor Manuel Jáquez Leal 2017-08-08 15:49:27 +02:00
parent d879664a0a
commit 067968ae74
1 changed files with 4 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
gst-libs/gst/vaapi/gstvaapidecoder_h265.c
View file

@ -717,8 +717,10 @@ dpb_find_lowest_poc (GstVaapiDecoderH265 * decoder,
GstVaapiPictureH265 *const picture = priv->dpb[i]->buffer; GstVaapiPictureH265 *const picture = priv->dpb[i]->buffer;
if (picture && !picture->output_needed) if (picture && !picture->output_needed)
continue; continue;
if (!found_picture || found_picture->poc > picture->poc) if (picture && (!found_picture || found_picture->poc > picture->poc)) {
found_picture = picture, found_index = i; found_picture = picture;
found_index = i;
}
} }
if (found_picture_ptr) if (found_picture_ptr)