mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2024-11-24 02:31:03 +00:00
Code Issues 1 Projects Releases Wiki Activity

gltestsrc: Fix potential NULL pointer dereference if we fail without GError

Browse source 
Which can happen here if we just propagate an error that happened
elsewhere, e.g. FBO failed.

CID 1364604
This commit is contained in:
Sebastian Dröge 2017-02-28 15:22:43 +02:00
parent a064590912
commit 0661a5aded
1 changed files with 7 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
ext/gl/gstgltestsrc.c
View file

@ -675,9 +675,13 @@ unsupported_gl_api:
} }
context_error: context_error:
{ {
GST_ELEMENT_ERROR (src, RESOURCE, NOT_FOUND, ("%s", error->message), if (error) {
(NULL)); GST_ELEMENT_ERROR (src, RESOURCE, NOT_FOUND, ("%s", error->message),
g_clear_error (&error); (NULL));
g_clear_error (&error);
} else {
GST_ELEMENT_ERROR (src, RESOURCE, NOT_FOUND, (NULL), (NULL));
}
if (src->context) if (src->context)
gst_object_unref (src->context); gst_object_unref (src->context);
src->context = NULL; src->context = NULL;