mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2024-10-04 01:32:42 +00:00
Code Issues 1 Projects Releases Wiki Activity

omx: always ignore OMX_ErrorPortUnpopulated

Browse source 
It is safe to ignore it always. Tizonia notifies this error to pass
some khronos conformance tests. Problem is that gst-omx saves this
error in comp->last_error and then gst_omx_port_set_enabled early
error out which fails the pipeline.

https://bugzilla.gnome.org/show_bug.cgi?id=782800
This commit is contained in:
Gurkirpal Singh 2017-05-07 20:09:54 +05:30 committed by Nicolas Dufresne
parent fc1a8229b0
commit 065878a5d4
1 changed files with 12 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
omx/gstomx.c
View file

@ -513,15 +513,25 @@ EventHandler (OMX_HANDLETYPE hComponent, OMX_PTR pAppData, OMX_EVENTTYPE eEvent,
case OMX_EventError:
{
GstOMXMessage *msg;
OMX_ERRORTYPE error_type = nData1;
/* Yes, this really happens... */
if (nData1 == OMX_ErrorNone)
if (error_type == OMX_ErrorNone)
break;
/* Always ignore PortUnpopulated error. This error is informational
* at best but it is useful for debugging some strange scenarios.
*/
if (error_type == OMX_ErrorPortUnpopulated) {
GST_DEBUG_OBJECT (comp->parent, "%s got error: %s (0x%08x)",
comp->name, gst_omx_error_to_string (error_type), error_type);
break;
}
msg = g_slice_new (GstOMXMessage);
msg->type = GST_OMX_MESSAGE_ERROR;
msg->content.error.error = nData1;
msg->content.error.error = error_type;
GST_ERROR_OBJECT (comp->parent, "%s got error: %s (0x%08x)", comp->name,
gst_omx_error_to_string (msg->content.error.error),
msg->content.error.error);