mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2025-03-29 12:25:37 +00:00
Code Issues 1 Projects Releases Wiki Activity

aggregator: Take pad lock while releasing buffers when removing pads

Browse source 
Accessing the buffers in all other places requires the pad lock and not
taking it here can cause access to already freed buffers if there's
concurrent access from another thread.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/5553>
This commit is contained in:
Sebastian Dröge 2023-10-19 19:43:26 +03:00 committed by Tim-Philipp Müller
parent 8419c1e6dc
commit 0596d637e2
1 changed files with 2 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
subprojects/gstreamer/libs/gst/base/gstaggregator.c
View file

@ -2032,7 +2032,9 @@ gst_aggregator_release_pad (GstElement * element, GstPad * pad)
SRC_LOCK (self);
gst_aggregator_pad_set_flushing (aggpad, GST_FLOW_FLUSHING, TRUE);
PAD_LOCK (aggpad);
gst_buffer_replace (&aggpad->priv->peeked_buffer, NULL);
PAD_UNLOCK (aggpad);
gst_element_remove_pad (element, pad);
self->priv->has_peer_latency = FALSE;