qtmux: gst_qtmux_check_difference verify before subtract

Avoid negative overflow by checking the order of operands
on subtraction of unsigned integers.

https://bugzilla.gnome.org/show_bug.cgi?id=635878
This commit is contained in:
Alejandro Gonzalez 2010-11-27 16:07:19 -06:00 committed by Tim-Philipp Müller
parent 9c198ffeed
commit 04b0a37f87

View file

@ -1904,7 +1904,7 @@ static gboolean inline
gst_qtmux_check_difference (GstQTMux * qtmux, GstClockTime a, gst_qtmux_check_difference (GstQTMux * qtmux, GstClockTime a,
GstClockTime b, GstClockTime magn) GstClockTime b, GstClockTime magn)
{ {
return ((a - b >= (magn >> 1)) || (b - a >= (magn >> 1))); return ((a >= b) ? (a - b >= (magn >> 1)) : (b - a >= (magn >> 1)));
} }
/* /*