mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2024-12-18 14:26:43 +00:00
Code Issues 1 Projects Releases Wiki Activity

id3demux: sizes in ID3 v2.3 are unlikely to be sync-safe integers

Browse source 
In ID3 v2.3 compressed frames will have a 4-byte data length indicator
after the frame header to indicate the size of the decompressed data.
This integer is unlikely to be a sync-safe integer for v2.3 tags,
only in v2.4 it's sync-safe.
This commit is contained in:
Tim-Philipp Müller 2009-08-07 16:42:39 +01:00
parent 3ec0a31d64
commit 0417283077
1 changed files with 5 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
gst/id3demux/id3v2frames.c
View file

@ -108,7 +108,11 @@ id3demux_id3v2_parse_frame (ID3TagsWorking * work)
ID3V2_FRAME_FORMAT_DATA_LENGTH_INDICATOR)) {
if (work->hdr.frame_data_size <= 4)
return FALSE;
work->parse_size = read_synch_uint (frame_data, 4);
if (ID3V2_VER_MAJOR (work->hdr.version) == 3) {
work->parse_size = GST_READ_UINT32_BE (frame_data);
} else {
work->parse_size = read_synch_uint (frame_data, 4);
}
frame_data += 4;
frame_data_size -= 4;
if (work->parse_size < frame_data_size) {