mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2025-01-31 03:29:50 +00:00
Code Issues 1 Projects Releases Wiki Activity

docs: Fix cache invalidation status

Browse source 
The dictionnary is updated in place so we were checking the same twice
This commit is contained in:
Thibault Saunier 2019-05-13 22:47:05 -04:00
parent 21428feac7
commit 039bbb99a6
1 changed files with 12 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

20
docs/gst-plugins-doc-cache-generator.py
View file

@ -39,34 +39,38 @@ BUILD_ROOT = "@BUILD_ROOT@"
def dict_recursive_update(d, u): def dict_recursive_update(d, u):
modified = False
unstable_values = d.get(UNSTABLE_VALUE, []) unstable_values = d.get(UNSTABLE_VALUE, [])
if not isinstance(unstable_values, list): if not isinstance(unstable_values, list):
unstable_values = [unstable_values] unstable_values = [unstable_values]
for k, v in u.items(): for k, v in u.items():
if isinstance(v, Mapping): if isinstance(v, Mapping):
r = dict_recursive_update(d.get(k, {}), v) r = d.get(k, {})
modified |= dict_recursive_update(r, v)
d[k] = r d[k] = r
elif k not in unstable_values: elif k not in unstable_values:
d[k] = u[k] d[k] = u[k]
return d modified = True
return modified
def test_unstable_values(): def test_unstable_values():
current_cache = { "v1": "yes", "unstable-values": "v1"} current_cache = { "v1": "yes", "unstable-values": "v1"}
new_cache = { "v1": "no" } new_cache = { "v1": "no" }
assert(dict_recursive_update(current_cache, new_cache) == current_cache) assert(dict_recursive_update(current_cache, new_cache) == False)
new_cache = { "v1": "no", "unstable-values": "v2" } new_cache = { "v1": "no", "unstable-values": "v2" }
assert(dict_recursive_update(current_cache, new_cache) == new_cache) assert(dict_recursive_update(current_cache, new_cache) == True)
current_cache = { "v1": "yes", "v2": "yay", "unstable-values": "v1",} current_cache = { "v1": "yes", "v2": "yay", "unstable-values": "v1",}
new_cache = { "v1": "no" } new_cache = { "v1": "no" }
assert(dict_recursive_update(current_cache, new_cache) == current_cache) assert(dict_recursive_update(current_cache, new_cache) == False)
current_cache = { "v1": "yes", "v2": "yay", "unstable-values": "v2"} current_cache = { "v1": "yes", "v2": "yay", "unstable-values": "v2"}
new_cache = { "v1": "no", "v2": "unstable" } new_cache = { "v1": "no", "v2": "unstable" }
assert(dict_recursive_update(current_cache, new_cache) == { "v1": "no", "v2": "yay", "unstable-values": "v2" }) assert (dict_recursive_update(current_cache, new_cache) == True)
assert (current_cache == { "v1": "no", "v2": "yay", "unstable-values": "v2" })
if __name__ == "__main__": if __name__ == "__main__":
cache_filename = sys.argv[1] cache_filename = sys.argv[1]
@ -112,11 +116,11 @@ if __name__ == "__main__":
print("Could not decode:\n%s" % data.decode(), file=sys.stderr) print("Could not decode:\n%s" % data.decode(), file=sys.stderr)
raise raise
new_cache = dict_recursive_update(cache, plugins) modified = dict_recursive_update(cache, plugins)
with open(output_filename, 'w') as f: with open(output_filename, 'w') as f:
json.dump(cache, f, indent=4, sort_keys=True) json.dump(cache, f, indent=4, sort_keys=True)
if new_cache != cache: if modified:
with open(cache_filename, 'w') as f: with open(cache_filename, 'w') as f:
json.dump(cache, f, indent=4, sort_keys=True) json.dump(cache, f, indent=4, sort_keys=True)