mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2024-11-27 04:01:08 +00:00
Code Issues 1 Projects Releases Wiki Activity

mpegtsdemux: fix operator precedence in SAFE_FOURCC_ARGS

Browse source 
Type cast has higher precedence than bitwise shift, so the third
argument will truncate to 8 bits and then shift right by 8 bits
resulting in constant zero.

https://bugzilla.gnome.org/show_bug.cgi?id=774293
This commit is contained in:
Scott D Phillips 2016-11-11 10:51:49 -08:00 committed by Sebastian Dröge
parent cff42b2b40
commit 0345fb8aef
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
gst/mpegtsdemux/gstmpegdefs.h
View file

@ -33,8 +33,8 @@
#define SAFE_FOURCC_ARGS(a) \
((guint8) ((a)>>24)), \
((guint8) ((a) >> 16 & 0xff)), \
((guint8) a >> 8 & 0xff), \
((guint8) a & 0xff), \
((guint8) ((a) >> 8 & 0xff)), \
((guint8) ((a) & 0xff)), \
SAFE_CHAR((a)>>24), \
SAFE_CHAR((a) >> 16 & 0xff), \
SAFE_CHAR((a) >> 8 & 0xff), \