mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2025-06-06 15:38:53 +00:00
Code Issues 1 Projects Releases Wiki Activity

srtp: zero out session member on dealloc

Browse source 
Fixes a user-after-free retrieving stats from _get_property()
This commit is contained in:
Matthew Waters 2017-08-24 18:00:41 +10:00
parent 63dd27a785
commit 029e01743f
2 changed files with 6 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
ext/srtp/gstsrtpdec.c
View file

@ -777,8 +777,10 @@ gst_srtp_dec_clear_streams (GstSrtpDec * filter)
GST_OBJECT_LOCK (filter); GST_OBJECT_LOCK (filter);
if (!filter->first_session) if (!filter->first_session) {
srtp_dealloc (filter->session); srtp_dealloc (filter->session);
filter->session = NULL;
}
if (filter->streams) if (filter->streams)
nb = g_hash_table_foreach_remove (filter->streams, remove_yes, NULL); nb = g_hash_table_foreach_remove (filter->streams, remove_yes, NULL);

4
ext/srtp/gstsrtpenc.c
View file

@ -447,8 +447,10 @@ gst_srtp_enc_create_session (GstSrtpEnc * filter)
static void static void
gst_srtp_enc_reset_no_lock (GstSrtpEnc * filter) gst_srtp_enc_reset_no_lock (GstSrtpEnc * filter)
{ {
if (!filter->first_session) if (!filter->first_session) {
srtp_dealloc (filter->session); srtp_dealloc (filter->session);
filter->session = NULL;
}
filter->first_session = TRUE; filter->first_session = TRUE;
filter->key_changed = FALSE; filter->key_changed = FALSE;