mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2025-02-03 04:52:28 +00:00
Code Issues 1 Projects Releases Wiki Activity

mpegtsmux: fix broken pad caps refcount handling

Browse source 
gst_caps_make_writable() takes ownership of the caps passed in, but
the caller doesn't own a ref to the caps here, because GST_PAD_CAPS
doesn't return a ref. Looks like the code relied on a caps leak
elsewhere for this to work properly.
This commit is contained in:
Tim-Philipp Müller 2011-03-14 12:39:23 +00:00
parent 70e71562b7
commit 0276663d0c
1 changed files with 3 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
gst/mpegtsmux/mpegtsmux.c
View file

@ -946,10 +946,10 @@ mpegtsdemux_set_header_on_caps (MpegTsMux * mux)
GstStructure *structure; GstStructure *structure;
GValue array = { 0 }; GValue array = { 0 };
GValue value = { 0 }; GValue value = { 0 };
GstCaps *caps = GST_PAD_CAPS (mux->srcpad); GstCaps *caps;
GList *sh; GList *sh;
caps = gst_caps_make_writable (caps); caps = gst_caps_copy (GST_PAD_CAPS (mux->srcpad));
structure = gst_caps_get_structure (caps, 0); structure = gst_caps_get_structure (caps, 0);
g_value_init (&array, GST_TYPE_ARRAY); g_value_init (&array, GST_TYPE_ARRAY);
@ -987,6 +987,7 @@ mpegtsdemux_prepare_srcpad (MpegTsMux * mux)
/* Set caps on src pad from our template and push new segment */ /* Set caps on src pad from our template and push new segment */
gst_pad_set_caps (mux->srcpad, caps); gst_pad_set_caps (mux->srcpad, caps);
gst_caps_unref (caps);
if (!gst_pad_push_event (mux->srcpad, new_seg)) { if (!gst_pad_push_event (mux->srcpad, new_seg)) {
GST_WARNING_OBJECT (mux, "New segment event was not handled downstream"); GST_WARNING_OBJECT (mux, "New segment event was not handled downstream");