mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2025-01-10 17:35:59 +00:00
Code Issues 1 Projects Releases Wiki Activity

hlsdemux2: Fix reference leak of variant stream

Browse source 
When switching back to the previous variant stream
in gst_hls_demux_change_playlist(), fix a couple of
paths that would leak a reference to the previous
variant.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2873>
This commit is contained in:
Jan Schmidt 2022-08-11 05:17:05 +10:00 committed by GStreamer Marge Bot
parent 9db19a3b06
commit 025e446470
1 changed files with 8 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
subprojects/gst-plugins-good/ext/adaptivedemux2/hls/gsthlsdemux.c
View file

@ -2673,16 +2673,22 @@ retry_failover_protection:
} }
gst_hls_demux_set_current_variant (demux, previous_variant); gst_hls_demux_set_current_variant (demux, previous_variant);
/* Try a lower bitrate (or stop if we just tried the lowest) */ /* Try a lower bitrate (or stop if we just tried the lowest) */
if (previous_variant->iframe) { if (previous_variant->iframe) {
lowest_ivariant = demux->master->iframe_variants->data; lowest_ivariant = demux->master->iframe_variants->data;
if (new_bandwidth == lowest_ivariant->bandwidth) if (new_bandwidth == lowest_ivariant->bandwidth) {
gst_hls_variant_stream_unref (previous_variant);
return FALSE; return FALSE;
}
} else { } else {
lowest_variant = demux->master->variants->data; lowest_variant = demux->master->variants->data;
if (new_bandwidth == lowest_variant->bandwidth) if (new_bandwidth == lowest_variant->bandwidth) {
gst_hls_variant_stream_unref (previous_variant);
return FALSE; return FALSE;
}
} }
gst_hls_variant_stream_unref (previous_variant);
return gst_hls_demux_change_playlist (demux, new_bandwidth - 1, changed); return gst_hls_demux_change_playlist (demux, new_bandwidth - 1, changed);
} }