mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2025-02-22 14:06:23 +00:00
Code Issues 1 Projects Releases Wiki Activity

validate: Fix marking expected issues as criticals

Browse source 
And never mark a repeat expected reports as repeated

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-devtools/-/merge_requests/207>
This commit is contained in:
Thibault Saunier 2020-06-15 09:08:51 -04:00 committed by GStreamer Merge Bot
parent b23cb6236d
commit 02339bd8bb
2 changed files with 6 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
validate/gst/validate/gst-validate-reporter.c
View file

@ -218,7 +218,7 @@ gst_validate_report_valist (GstValidateReporter * reporter,
prev_report = g_hash_table_lookup (priv->reports, (gconstpointer) issue_id); prev_report = g_hash_table_lookup (priv->reports, (gconstpointer) issue_id);
runner = gst_validate_reporter_get_runner (reporter); runner = gst_validate_reporter_get_runner (reporter);
if (prev_report) { if (prev_report && prev_report->level != GST_VALIDATE_REPORT_LEVEL_EXPECTED) {
GstValidateReportingDetails reporter_level = GstValidateReportingDetails reporter_level =
gst_validate_reporter_get_reporting_level (reporter); gst_validate_reporter_get_reporting_level (reporter);
GstValidateReportingDetails runner_level = GST_VALIDATE_SHOW_UNKNOWN; GstValidateReportingDetails runner_level = GST_VALIDATE_SHOW_UNKNOWN;

5
validate/gst/validate/gst-validate-runner.c
View file

@ -688,8 +688,10 @@ gst_validate_runner_add_report (GstValidateRunner * runner,
if (report->level == GST_VALIDATE_REPORT_LEVEL_IGNORE) if (report->level == GST_VALIDATE_REPORT_LEVEL_IGNORE)
return; return;
if (check_report_expected (runner, report)) if (check_report_expected (runner, report)) {
GST_INFO_OBJECT (runner, "Found expected issue: %p", report);
report->level = GST_VALIDATE_REPORT_LEVEL_EXPECTED; report->level = GST_VALIDATE_REPORT_LEVEL_EXPECTED;
}
gst_validate_send (json_boxed_serialize (GST_MINI_OBJECT_TYPE (report), gst_validate_send (json_boxed_serialize (GST_MINI_OBJECT_TYPE (report),
report)); report));
@ -824,6 +826,7 @@ _do_report_synthesis (GstValidateRunner * runner)
if ((report->level == GST_VALIDATE_REPORT_LEVEL_CRITICAL) || if ((report->level == GST_VALIDATE_REPORT_LEVEL_CRITICAL) ||
(report->issue->flags & GST_VALIDATE_ISSUE_FLAGS_FULL_DETAILS)) { (report->issue->flags & GST_VALIDATE_ISSUE_FLAGS_FULL_DETAILS)) {
if (report->level == GST_VALIDATE_REPORT_LEVEL_CRITICAL)
criticals = g_list_append (criticals, report); criticals = g_list_append (criticals, report);
gst_validate_report_print_details (report); gst_validate_report_print_details (report);
} }