mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2025-02-06 14:32:31 +00:00
Code Issues 1 Projects Releases Wiki Activity

opus: Fix a double-unref in the Opus header code

Browse source 
The headers were never getting reffed when being added to the headers
list, which is later unreffed-and-freed by the caller (e.g.
gst_opus_parse_parse_frame()).

https://bugzilla.gnome.org/show_bug.cgi?id=733013
This commit is contained in:
Philip Withnall 2014-07-10 15:52:46 +01:00 committed by Sebastian Dröge
parent fd77bb1eff
commit 01d2956c4e
1 changed files with 5 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
ext/opus/gstopusheader.c
View file

@ -190,8 +190,8 @@ gst_opus_header_create_caps_from_headers (GstCaps ** caps, GSList ** headers,
"multistream", G_TYPE_BOOLEAN, multistream, NULL); "multistream", G_TYPE_BOOLEAN, multistream, NULL);
*caps = _gst_caps_set_buffer_array (*caps, "streamheader", buf1, buf2, NULL); *caps = _gst_caps_set_buffer_array (*caps, "streamheader", buf1, buf2, NULL);
*headers = g_slist_prepend (*headers, buf2); *headers = g_slist_prepend (*headers, gst_buffer_ref (buf2));
*headers = g_slist_prepend (*headers, buf1); *headers = g_slist_prepend (*headers, gst_buffer_ref (buf1));
} }
void void
@ -218,6 +218,9 @@ gst_opus_header_create_caps (GstCaps ** caps, GSList ** headers, gint nchannels,
buf2 = gst_opus_enc_create_metadata_buffer (tags); buf2 = gst_opus_enc_create_metadata_buffer (tags);
gst_opus_header_create_caps_from_headers (caps, headers, buf1, buf2); gst_opus_header_create_caps_from_headers (caps, headers, buf1, buf2);
gst_buffer_unref (buf2);
gst_buffer_unref (buf1);
} }
gboolean gboolean