mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2024-12-22 00:06:36 +00:00
Code Issues 1 Projects Releases Wiki Activity

tests: Use a different rate in a segment test.

Browse source 
Using a rate of 1.1 in the test is causing the test to
fail on 32-bit because ceil(1.1 * 10) can round to 12.

Instead use a rate 2.0 that can be expressed as floating
point number and doesn't trigger the problem.

https://bugzilla.gnome.org/show_bug.cgi?id=797154
This commit is contained in:
Jan Schmidt 2018-09-17 22:13:22 +10:00
parent c81b2f6207
commit 01758dcf6a
1 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
tests/check/gst/gstsegment.c
View file

@ -888,7 +888,7 @@ GST_START_TEST (segment_full)
fail_unless_equals_int (pos, 190); fail_unless_equals_int (pos, 190);
/* Test a non-1.0 rate that lands right before the segment, but still +ve */ /* Test a non-1.0 rate that lands right before the segment, but still +ve */
segment.rate = 1.1; segment.rate = 2.0;
segment.start = 100; segment.start = 100;
segment.offset = 0; segment.offset = 0;
segment.stop = 500; segment.stop = 500;
@ -897,11 +897,11 @@ GST_START_TEST (segment_full)
segment.time = 10000; segment.time = 10000;
fail_unless (gst_segment_position_from_running_time_full (&segment, fail_unless (gst_segment_position_from_running_time_full (&segment,
GST_FORMAT_TIME, 140, &pos) == 1); GST_FORMAT_TIME, 140, &pos) == 1);
fail_unless (pos == 89); fail_unless (pos == 80);
/* And now one that should give a position < 0 */ /* And now one that should give a position < 0 */
fail_unless (gst_segment_position_from_running_time_full (&segment, fail_unless (gst_segment_position_from_running_time_full (&segment,
GST_FORMAT_TIME, 0, &pos) == -1); GST_FORMAT_TIME, 0, &pos) == -1);
fail_unless (pos == 65); fail_unless (pos == 200);
/* Test a non-1.0 negative rate that lands right after the (reversed) segment, but still +ve position */ /* Test a non-1.0 negative rate that lands right after the (reversed) segment, but still +ve position */
segment.rate = -2.0; segment.rate = -2.0;