mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2024-11-24 02:31:03 +00:00
Code Issues 1 Projects Releases Wiki Activity

tests: rtprtx::test_rtxreceive_data_reconstruction: remove useless code for triggering retransmission

Browse source 
There is no need anymore to push yet another buffer in rtxsend
in order to trigger the previously requested retransmissions
to actually happen.
This commit is contained in:
George Kiagiadakis 2014-01-15 17:29:35 +01:00 committed by Wim Taymans
parent 184553151d
commit 016e1562a6
1 changed files with 2 additions and 13 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
tests/check/elements/rtprtx.c
View file

@ -1409,7 +1409,6 @@ GST_START_TEST (test_rtxreceive_data_reconstruction)
GstElement *rtxsend, *rtxrecv; GstElement *rtxsend, *rtxrecv;
GstPad *srcpad, *sinkpad; GstPad *srcpad, *sinkpad;
GstCaps *caps; GstCaps *caps;
GstRTPBuffer rtp = GST_RTP_BUFFER_INIT;
GstBuffer *buffer; GstBuffer *buffer;
GstStructure *pt_map; GstStructure *pt_map;
@ -1449,8 +1448,7 @@ GST_START_TEST (test_rtxreceive_data_reconstruction)
/* push buffer */ /* push buffer */
buffer = gst_buffer_ref (GST_BUFFER (in_buffers->data)); buffer = gst_buffer_ref (GST_BUFFER (in_buffers->data));
fail_unless_equals_int (gst_pad_push (srcpad, gst_buffer_ref (buffer)), fail_unless_equals_int (gst_pad_push (srcpad, buffer), GST_FLOW_OK);
GST_FLOW_OK);
/* push retransmission request */ /* push retransmission request */
{ {
@ -1473,21 +1471,12 @@ GST_START_TEST (test_rtxreceive_data_reconstruction)
g_mutex_unlock (&check_mutex); g_mutex_unlock (&check_mutex);
} }
/* push with the next seqnum to trigger retransmission in rtxsend */
buffer = gst_buffer_make_writable (buffer);
gst_rtp_buffer_map (buffer, GST_MAP_WRITE, &rtp);
gst_rtp_buffer_set_seq (&rtp, 2);
gst_rtp_buffer_unmap (&rtp);
fail_unless_equals_int (gst_pad_push (srcpad, gst_buffer_ref (buffer)),
GST_FLOW_OK);
/* verify */ /* verify */
fail_unless_equals_int (g_list_length (buffers), 3); fail_unless_equals_int (g_list_length (buffers), 2);
compare_rtp_packets (GST_BUFFER (buffers->data), compare_rtp_packets (GST_BUFFER (buffers->data),
GST_BUFFER (buffers->next->data)); GST_BUFFER (buffers->next->data));
/* cleanup */ /* cleanup */
gst_buffer_unref (buffer);
g_list_free_full (in_buffers, (GDestroyNotify) gst_buffer_unref); g_list_free_full (in_buffers, (GDestroyNotify) gst_buffer_unref);
gst_check_drop_buffers (); gst_check_drop_buffers ();