mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2024-12-18 14:26:43 +00:00
Code Issues 1 Projects Releases Wiki Activity

gst-libs/gst/tag/gstvorbistag.c: Add comment about LANGUAGE tag inconsistency (we want

Browse source 
Original commit message from CVS:
* gst-libs/gst/tag/gstvorbistag.c: (gst_vorbis_tag_add):
Add comment about LANGUAGE tag inconsistency (we want
ISO-639-1, but extract three-letter identifiers?)
* po/POTFILES.in:
Add two translatable files.
This commit is contained in:
Tim-Philipp Müller 2006-02-05 15:14:06 +00:00
parent ce175c9953
commit 00e0574b1f
3 changed files with 15 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
ChangeLog
View file

@ -1,3 +1,12 @@
2006-02-05 Tim-Philipp Müller <tim at centricular dot net>
* gst-libs/gst/tag/gstvorbistag.c: (gst_vorbis_tag_add):
Add comment about LANGUAGE tag inconsistency (we want
ISO-639-1, but extract three-letter identifiers?)
* po/POTFILES.in:
Add two translatable files.
2006-02-05 Tim-Philipp Müller <tim at centricular dot net> 2006-02-05 Tim-Philipp Müller <tim at centricular dot net>
* gst-libs/gst/tag/Makefile.am: * gst-libs/gst/tag/Makefile.am:

4
gst-libs/gst/tag/gstvorbistag.c
View file

@ -159,6 +159,10 @@ gst_vorbis_tag_add (GstTagList * list, const gchar * tag, const gchar * value)
if (strcmp (tag, "LANGUAGE") == 0) { if (strcmp (tag, "LANGUAGE") == 0) {
const gchar *s = strchr (value, '['); const gchar *s = strchr (value, '[');
/* FIXME: gsttaglist.h says our language tag contains ISO-639-1
* codes, which are 2 letter codes. The code below extracts 3-letter
* identifiers, which would be ISO-639-2. Mixup? Oversight? Wrong core
* docs? What do files in the wild contain? (tpm) */
if (s && strchr (s, ']') == s + 4) { if (s && strchr (s, ']') == s + 4) {
valid = g_strndup (s + 1, 3); valid = g_strndup (s + 1, 3);
} }

2
po/POTFILES.in
View file

@ -5,3 +5,5 @@ ext/gnomevfs/gstgnomevfssink.c
ext/ogg/gstoggdemux.c ext/ogg/gstoggdemux.c
gst/playback/gstplaybasebin.c gst/playback/gstplaybasebin.c
gst/playback/gstplaybin.c gst/playback/gstplaybin.c
gst-libs/gst/tag/tags.c
gst-libs/gst/cdda/gstcddabasesrc.c