mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2025-03-30 12:49:40 +00:00
Code Issues 1 Projects Releases Wiki Activity

rtspsrc: Avoid stack overflow recursing waiting for response

Browse source 
Instead of recursing, simply implement a loop with gotos, the same
way it was done before 8121752887

Fixes https://gitlab.freedesktop.org/gstreamer/gst-plugins-good/-/issues/710
This commit is contained in:
Thibault Saunier 2020-04-08 09:45:17 -04:00
parent cf3fbf57bf
commit 00539e1277
1 changed files with 7 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
gst/rtsp/gstrtspsrc.c
View file

@ -6325,7 +6325,10 @@ gst_rtsp_src_receive_response (GstRTSPSrc * src, GstRTSPConnInfo * conninfo,
{ {
GstRTSPStatusCode thecode; GstRTSPStatusCode thecode;
gchar *content_base = NULL; gchar *content_base = NULL;
GstRTSPResult res = gst_rtspsrc_connection_receive (src, conninfo, response, GstRTSPResult res;
next:
res = gst_rtspsrc_connection_receive (src, conninfo, response,
src->tcp_timeout); src->tcp_timeout);
if (res < 0) if (res < 0)
@ -6342,7 +6345,7 @@ gst_rtsp_src_receive_response (GstRTSPSrc * src, GstRTSPConnInfo * conninfo,
goto handle_request_failed; goto handle_request_failed;
/* Not a response, receive next message */ /* Not a response, receive next message */
return gst_rtsp_src_receive_response (src, conninfo, response, code); goto next;
case GST_RTSP_MESSAGE_RESPONSE: case GST_RTSP_MESSAGE_RESPONSE:
/* ok, a response is good */ /* ok, a response is good */
GST_DEBUG_OBJECT (src, "received response message"); GST_DEBUG_OBJECT (src, "received response message");
@ -6353,13 +6356,13 @@ gst_rtsp_src_receive_response (GstRTSPSrc * src, GstRTSPConnInfo * conninfo,
gst_rtspsrc_handle_data (src, response); gst_rtspsrc_handle_data (src, response);
/* Not a response, receive next message */ /* Not a response, receive next message */
return gst_rtsp_src_receive_response (src, conninfo, response, code); goto next;
default: default:
GST_WARNING_OBJECT (src, "ignoring unknown message type %d", GST_WARNING_OBJECT (src, "ignoring unknown message type %d",
response->type); response->type);
/* Not a response, receive next message */ /* Not a response, receive next message */
return gst_rtsp_src_receive_response (src, conninfo, response, code); goto next;
} }
thecode = response->type_data.response.code; thecode = response->type_data.response.code;