Handle changing playback rate
Before this patch, NLE and GES did not support NleOperations (respectively
GESEffects) that changed the speed/tempo/rate at which the source plays. For
example, the 'pitch' element can make audio play faster or slower. In GES 1.5.90
and before, an NleOperation containing the pitch element to change the rate (or
tempo) would cause a pipeline state change to PAUSED after that stack; that has
been fixed in 1.5.91 (see #755012 [0]). But even then, in 1.5.91 and later,
NleComposition would send segment events to its NleSources assuming that one
source second is equal to one pipeline second. The resulting early EOS event
(in the case of a source rate higher than 1.0) would cause it to switch stacks
too early, causing confusion in the timeline and spectacularly messed up
output.
This patch fixes that by searching for rate-changing elements in
GESTrackElements such as GESEffects. If such rate-changing elements are found,
their final effect on the playing rate is stored in the corresponding NleObject
as the 'media duration factor', named like this because the 'media duration',
or source duration, of an NleObject can be computed by multiplying the duration
with the media duration factor of that object and its parents (this is called
the 'recursive media duration factor'). For example, a 4-second NleSource with
an NleOperation with a media duration factor of 2.0 will have an 8-second media
duration, which means that for playing 4 seconds in the pipeline, the seek
event sent to it must span 8 seconds of media. (So, the 'duration' of an
NleObject or GES object always refers to its duration in the timeline, not the
media duration.)
To summarize:
* Rate-changing elements are registered in the GESEffectClass (pitch::tempo and
pitch::rate are registered by default);
* GESTimelineElement is responsible for detecting rate-changing elements and
computing the media_duration_factor;
* GESTrackElement is responsible for storing the media_duration_factor in
NleObject;
* NleComposition is responsible for the recursive_media_duration_factor;
* The latter property finally fixes media time computations in NleObject.
NLE and GES tests are included.
[0] https://bugzilla.gnome.org/show_bug.cgi?id=755012
Differential Revision: https://phabricator.freedesktop.org/D276
2015-12-20 13:03:57 +00:00
|
|
|
/* GStreamer Editing Services
|
|
|
|
|
* Copyright (C) 2016 Sjors Gielen <mixml-ges@sjorsgielen.nl>
|
|
|
|
|
*
|
|
|
|
|
* This library is free software; you can redistribute it and/or
|
|
|
|
|
* modify it under the terms of the GNU Library General Public
|
|
|
|
|
* License as published by the Free Software Foundation; either
|
|
|
|
|
* version 2 of the License, or (at your option) any later version.
|
|
|
|
|
*
|
|
|
|
|
* This library is distributed in the hope that it will be useful,
|
|
|
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
|
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
|
|
|
|
* Library General Public License for more details.
|
|
|
|
|
*
|
|
|
|
|
* You should have received a copy of the GNU Library General Public
|
|
|
|
|
* License along with this library; if not, write to the
|
|
|
|
|
* Free Software Foundation, Inc., 51 Franklin St, Fifth Floor,
|
|
|
|
|
* Boston, MA 02110-1301, USA.
|
|
|
|
|
*/
|
|
|
|
|
|
|
|
|
|
#include "test-utils.h"
|
|
|
|
|
#include <ges/ges.h>
|
|
|
|
|
#include <gst/check/gstcheck.h>
|
|
|
|
|
#include <plugins/nle/nleobject.h>
|
|
|
|
|
|
|
|
|
|
GST_START_TEST (test_tempochange)
|
|
|
|
|
{
|
|
|
|
|
GESTimeline *timeline;
|
|
|
|
|
GESLayer *layer;
|
|
|
|
|
GESTrack *track_audio;
|
|
|
|
|
GESEffect *effect;
|
|
|
|
|
GESTestClip *clip;
|
|
|
|
|
GESClip *clip2, *clip3;
|
|
|
|
|
|
2019-01-28 02:24:29 +00:00
|
|
|
ges_init ();
|
|
|
|
|
|
Handle changing playback rate
Before this patch, NLE and GES did not support NleOperations (respectively
GESEffects) that changed the speed/tempo/rate at which the source plays. For
example, the 'pitch' element can make audio play faster or slower. In GES 1.5.90
and before, an NleOperation containing the pitch element to change the rate (or
tempo) would cause a pipeline state change to PAUSED after that stack; that has
been fixed in 1.5.91 (see #755012 [0]). But even then, in 1.5.91 and later,
NleComposition would send segment events to its NleSources assuming that one
source second is equal to one pipeline second. The resulting early EOS event
(in the case of a source rate higher than 1.0) would cause it to switch stacks
too early, causing confusion in the timeline and spectacularly messed up
output.
This patch fixes that by searching for rate-changing elements in
GESTrackElements such as GESEffects. If such rate-changing elements are found,
their final effect on the playing rate is stored in the corresponding NleObject
as the 'media duration factor', named like this because the 'media duration',
or source duration, of an NleObject can be computed by multiplying the duration
with the media duration factor of that object and its parents (this is called
the 'recursive media duration factor'). For example, a 4-second NleSource with
an NleOperation with a media duration factor of 2.0 will have an 8-second media
duration, which means that for playing 4 seconds in the pipeline, the seek
event sent to it must span 8 seconds of media. (So, the 'duration' of an
NleObject or GES object always refers to its duration in the timeline, not the
media duration.)
To summarize:
* Rate-changing elements are registered in the GESEffectClass (pitch::tempo and
pitch::rate are registered by default);
* GESTimelineElement is responsible for detecting rate-changing elements and
computing the media_duration_factor;
* GESTrackElement is responsible for storing the media_duration_factor in
NleObject;
* NleComposition is responsible for the recursive_media_duration_factor;
* The latter property finally fixes media time computations in NleObject.
NLE and GES tests are included.
[0] https://bugzilla.gnome.org/show_bug.cgi?id=755012
Differential Revision: https://phabricator.freedesktop.org/D276
2015-12-20 13:03:57 +00:00
|
|
|
timeline = ges_timeline_new ();
|
|
|
|
|
layer = ges_layer_new ();
|
|
|
|
|
track_audio = GES_TRACK (ges_audio_track_new ());
|
|
|
|
|
|
|
|
|
|
ges_timeline_add_track (timeline, track_audio);
|
|
|
|
|
ges_timeline_add_layer (timeline, layer);
|
|
|
|
|
|
|
|
|
|
/* Add a 9-second clip */
|
|
|
|
|
clip = ges_test_clip_new ();
|
|
|
|
|
g_object_set (clip, "duration", 9 * GST_SECOND, NULL);
|
|
|
|
|
ges_layer_add_clip (layer, (GESClip *) clip);
|
|
|
|
|
|
|
|
|
|
/* Split it after 3 seconds */
|
|
|
|
|
clip2 = ges_clip_split ((GESClip *) clip, 3 * GST_SECOND);
|
|
|
|
|
|
|
|
|
|
/* Add pitch effect to play 1.5 times faster */
|
|
|
|
|
effect = ges_effect_new ("pitch tempo=1.5");
|
|
|
|
|
|
|
|
|
|
fail_unless (GES_IS_EFFECT (effect));
|
|
|
|
|
fail_unless (ges_container_add (GES_CONTAINER (clip2),
|
|
|
|
|
GES_TIMELINE_ELEMENT (effect)));
|
|
|
|
|
fail_unless (ges_track_element_get_track (GES_TRACK_ELEMENT (effect)) !=
|
|
|
|
|
NULL);
|
|
|
|
|
|
|
|
|
|
assert_equals_int (GES_TRACK_ELEMENT (effect)->active, TRUE);
|
|
|
|
|
|
|
|
|
|
/* Split clip again after 6 seconds (note: this is timeline time) */
|
|
|
|
|
clip3 = ges_clip_split (clip2, 6 * GST_SECOND);
|
|
|
|
|
|
|
|
|
|
// note: start and duration are counted in timeline time, while
|
|
|
|
|
// inpoint is counted in media time.
|
|
|
|
|
fail_unless_equals_int64 (_START (clip), 0 * GST_SECOND);
|
|
|
|
|
fail_unless_equals_int64 (_INPOINT (clip), 0 * GST_SECOND);
|
|
|
|
|
fail_unless_equals_int64 (_DURATION (clip), 3 * GST_SECOND);
|
|
|
|
|
|
|
|
|
|
fail_unless_equals_int64 (_START (clip2), 3 * GST_SECOND);
|
|
|
|
|
fail_unless_equals_int64 (_INPOINT (clip2), 3 * GST_SECOND);
|
|
|
|
|
fail_unless_equals_int64 (_DURATION (clip2), 3 * GST_SECOND);
|
|
|
|
|
|
|
|
|
|
fail_unless_equals_int64 (_START (clip3), 6 * GST_SECOND);
|
|
|
|
|
fail_unless_equals_int64 (_INPOINT (clip3), 7.5 * GST_SECOND);
|
|
|
|
|
fail_unless_equals_int64 (_DURATION (clip3), 3 * GST_SECOND);
|
|
|
|
|
|
|
|
|
|
gst_object_unref (timeline);
|
2019-01-28 02:24:29 +00:00
|
|
|
|
|
|
|
|
ges_deinit ();
|
Handle changing playback rate
Before this patch, NLE and GES did not support NleOperations (respectively
GESEffects) that changed the speed/tempo/rate at which the source plays. For
example, the 'pitch' element can make audio play faster or slower. In GES 1.5.90
and before, an NleOperation containing the pitch element to change the rate (or
tempo) would cause a pipeline state change to PAUSED after that stack; that has
been fixed in 1.5.91 (see #755012 [0]). But even then, in 1.5.91 and later,
NleComposition would send segment events to its NleSources assuming that one
source second is equal to one pipeline second. The resulting early EOS event
(in the case of a source rate higher than 1.0) would cause it to switch stacks
too early, causing confusion in the timeline and spectacularly messed up
output.
This patch fixes that by searching for rate-changing elements in
GESTrackElements such as GESEffects. If such rate-changing elements are found,
their final effect on the playing rate is stored in the corresponding NleObject
as the 'media duration factor', named like this because the 'media duration',
or source duration, of an NleObject can be computed by multiplying the duration
with the media duration factor of that object and its parents (this is called
the 'recursive media duration factor'). For example, a 4-second NleSource with
an NleOperation with a media duration factor of 2.0 will have an 8-second media
duration, which means that for playing 4 seconds in the pipeline, the seek
event sent to it must span 8 seconds of media. (So, the 'duration' of an
NleObject or GES object always refers to its duration in the timeline, not the
media duration.)
To summarize:
* Rate-changing elements are registered in the GESEffectClass (pitch::tempo and
pitch::rate are registered by default);
* GESTimelineElement is responsible for detecting rate-changing elements and
computing the media_duration_factor;
* GESTrackElement is responsible for storing the media_duration_factor in
NleObject;
* NleComposition is responsible for the recursive_media_duration_factor;
* The latter property finally fixes media time computations in NleObject.
NLE and GES tests are included.
[0] https://bugzilla.gnome.org/show_bug.cgi?id=755012
Differential Revision: https://phabricator.freedesktop.org/D276
2015-12-20 13:03:57 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
GST_END_TEST;
|
|
|
|
|
|
|
|
|
|
static Suite *
|
|
|
|
|
ges_suite (void)
|
|
|
|
|
{
|
|
|
|
|
Suite *s = suite_create ("ges");
|
|
|
|
|
GstPluginFeature *pitch = gst_registry_find_feature (gst_registry_get (),
|
|
|
|
|
"pitch", GST_TYPE_ELEMENT_FACTORY);
|
|
|
|
|
|
|
|
|
|
if (pitch) {
|
2020-04-09 14:54:26 +00:00
|
|
|
TCase *tc_chain = tcase_create ("tempochange");
|
Handle changing playback rate
Before this patch, NLE and GES did not support NleOperations (respectively
GESEffects) that changed the speed/tempo/rate at which the source plays. For
example, the 'pitch' element can make audio play faster or slower. In GES 1.5.90
and before, an NleOperation containing the pitch element to change the rate (or
tempo) would cause a pipeline state change to PAUSED after that stack; that has
been fixed in 1.5.91 (see #755012 [0]). But even then, in 1.5.91 and later,
NleComposition would send segment events to its NleSources assuming that one
source second is equal to one pipeline second. The resulting early EOS event
(in the case of a source rate higher than 1.0) would cause it to switch stacks
too early, causing confusion in the timeline and spectacularly messed up
output.
This patch fixes that by searching for rate-changing elements in
GESTrackElements such as GESEffects. If such rate-changing elements are found,
their final effect on the playing rate is stored in the corresponding NleObject
as the 'media duration factor', named like this because the 'media duration',
or source duration, of an NleObject can be computed by multiplying the duration
with the media duration factor of that object and its parents (this is called
the 'recursive media duration factor'). For example, a 4-second NleSource with
an NleOperation with a media duration factor of 2.0 will have an 8-second media
duration, which means that for playing 4 seconds in the pipeline, the seek
event sent to it must span 8 seconds of media. (So, the 'duration' of an
NleObject or GES object always refers to its duration in the timeline, not the
media duration.)
To summarize:
* Rate-changing elements are registered in the GESEffectClass (pitch::tempo and
pitch::rate are registered by default);
* GESTimelineElement is responsible for detecting rate-changing elements and
computing the media_duration_factor;
* GESTrackElement is responsible for storing the media_duration_factor in
NleObject;
* NleComposition is responsible for the recursive_media_duration_factor;
* The latter property finally fixes media time computations in NleObject.
NLE and GES tests are included.
[0] https://bugzilla.gnome.org/show_bug.cgi?id=755012
Differential Revision: https://phabricator.freedesktop.org/D276
2015-12-20 13:03:57 +00:00
|
|
|
gst_object_unref (pitch);
|
|
|
|
|
|
|
|
|
|
suite_add_tcase (s, tc_chain);
|
|
|
|
|
tcase_add_test (tc_chain, test_tempochange);
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
return s;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
GST_CHECK_MAIN (ges);
|
