mirror of
https://github.com/superseriousbusiness/gotosocial.git
synced 2025-03-13 14:02:41 +00:00
424f62dd70
* Add ContentType to internal models * Add ContentType to API models StatusSource and StatusEdit * Add helpers to convert between API/internal StatusContentType * Write status content type on create/edit * Add migration * Update API docs go run github.com/go-swagger/go-swagger/cmd/swagger generate spec --scan-models --exclude-deps --output docs/api/swagger.yaml * ensure ContentType is updated anywhere Text is * Update docs, take care of TODOs * Set ContentType in more places where Text is set * We don't actually use ContentType on the API status model * Update StatusSource test * Remove unused helper function I copied * Revert change to StatusContentType swagger annotation I'm going to include this in a follow-on PR instead. * Add test for updating content type in edits * Return a value from processContentType instead of modifying the existing status Fixes an issue that was caught by the test I just added - the recorded edit would be marked with the *new* content type instead of the old one, which is obviously bad * Add test for handling of statuses with no stored content type * repurpose an existing test status instead of adding a new one to avoid breaking other tests * Add test to ensure newly created statuses always have content type saved * Do include content type on status API model actually This is mostly important when deleting and redrafting. The comment on `apimodel.Status.Text` implies that it's not sent except in response to status deletion, but actually this doesn't seem to be the case; it also appears to be present in responses to creations and normal fetches and stuff. So I'm treating `ContentType` the same here. * Update new tests to check content type on API statuses * Check content type of API statuses in all tests where text is checked * update other api tests with status content type field * Add test ensuring text and content type are returned when deleting a status * Convert processContentType to free function and remove unused parameter * check for the correct value in the deletion test * Be explicit about this test status having an empty content type * Use omitempty consistently on API models * clean up the final diff a bit * one more swagger regen for the road * Handle nil statuses in processContentType * Don't pass processContentType the entire edit form, it doesn't need it * Move processContentType to common.go and use for creation as well * Remove unused parameters to ContentTypeToAPIContentType |
||
|---|---|---|
| .. | ||
| account.go | ||
| accountnote.go | ||
| accountsettings.go | ||
| accountstats.go | ||
| adminaction.go | ||
| advancedmigration.go | ||
| application.go | ||
| block.go | ||
| common.go | ||
| conversation.go | ||
| domainallow.go | ||
| domainblock.go | ||
| domainpermission.go | ||
| domainpermissiondraft.go | ||
| domainpermissionexclude.go | ||
| domainpermissionsubscription.go | ||
| emaildomainblock.go | ||
| emoji.go | ||
| emojicategory.go | ||
| filter.go | ||
| follow.go | ||
| followrequest.go | ||
| headerfilter.go | ||
| instance.go | ||
| interaction.go | ||
| interactionpolicy.go | ||
| list.go | ||
| marker.go | ||
| mediaattachment.go | ||
| mention.go | ||
| move.go | ||
| notification.go | ||
| poll.go | ||
| README.md | ||
| report.go | ||
| routersession.go | ||
| rule.go | ||
| sinbinstatus.go | ||
| status.go | ||
| statusbookmark.go | ||
| statusedit.go | ||
| statusfave.go | ||
| statusmute.go | ||
| tag.go | ||
| thread.go | ||
| threadmute.go | ||
| token.go | ||
| tombstone.go | ||
| user.go | ||
| usermute.go | ||
| vapidkeypair.go | ||
| webpushsubscription.go | ||
| workertask.go | ||
A note on when we should set data structures linked to objects in the database to use the
bun nullzero tag -- this should only be done if the member type is a pointer, or if the
this primitive type is literally invalid with an empty value (e.g. media IDs which when
empty signifies a null database value, compared to say an account note which when empty
could mean either an empty note OR null database value).
Obviously it is a little more complex than this in practice, but keep it in mind!