mirror of
https://github.com/superseriousbusiness/gotosocial.git
synced 2025-10-04 16:49:40 +00:00
3cff4b2d7d
after seeing a potential reported federating worker lockup i decided to start digging into the federatingdb code. this PR encompasses:
- removes one of our last unused interface types `federatingdb.DB{}`, replacing it with a struct type `*federatingdb.DB{}`
- in `transport.dereferenceLocal()` differentiates between an unsupported lookup type and ErrNoEntries to reduce unnecessary calls, and reduce potential lockups that may occur while trying to call our own endpoints that then call `federatingdb.Lock()`
- removes a bunch of the locks on follow state changes since the DB already synchronizes that
- removes the unnecessary `pub.Clock{}` struct field and type passed to the transport controller
frankly it would be great if we could remove the locking in `federatingdb.Lock()` and instead handle it ourselves as it gets very confusing trying to figure out what functions will have locks held. but i guess that's one for when we move further away from the go-fed/activity/pub package usage.
Reviewed-on: https://codeberg.org/superseriousbusiness/gotosocial/pulls/4178
Co-authored-by: kim <grufwub@gmail.com>
Co-committed-by: kim <grufwub@gmail.com>
57 lines
1.9 KiB
Go
57 lines
1.9 KiB
Go
// GoToSocial
|
|
// Copyright (C) GoToSocial Authors admin@gotosocial.org
|
|
// SPDX-License-Identifier: AGPL-3.0-or-later
|
|
//
|
|
// This program is free software: you can redistribute it and/or modify
|
|
// it under the terms of the GNU Affero General Public License as published by
|
|
// the Free Software Foundation, either version 3 of the License, or
|
|
// (at your option) any later version.
|
|
//
|
|
// This program is distributed in the hope that it will be useful,
|
|
// but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
// GNU Affero General Public License for more details.
|
|
//
|
|
// You should have received a copy of the GNU Affero General Public License
|
|
// along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
|
|
package federatingdb
|
|
|
|
import (
|
|
"context"
|
|
"net/url"
|
|
|
|
"code.superseriousbusiness.org/activity/streams/vocab"
|
|
"code.superseriousbusiness.org/gotosocial/internal/gtserror"
|
|
)
|
|
|
|
// Following obtains the Following Collection for an actor with the
|
|
// given id.
|
|
//
|
|
// If modified, the library will then call Update.
|
|
//
|
|
// The library makes this call only after acquiring a lock first.
|
|
func (f *DB) Following(ctx context.Context, actorIRI *url.URL) (following vocab.ActivityStreamsCollection, err error) {
|
|
acct, err := f.state.DB.GetAccountByURI(ctx, actorIRI.String())
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
// Fetch follows for account from database.
|
|
follows, err := f.state.DB.GetAccountFollows(ctx, acct.ID, nil)
|
|
if err != nil {
|
|
return nil, gtserror.Newf("db error getting following for account id %s: %w", acct.ID, err)
|
|
}
|
|
|
|
// Convert the follows to a slice of account URIs.
|
|
iris := make([]*url.URL, 0, len(follows))
|
|
for _, follow := range follows {
|
|
u, err := url.Parse(follow.TargetAccount.URI)
|
|
if err != nil {
|
|
return nil, gtserror.Newf("invalid account uri: %v", err)
|
|
}
|
|
iris = append(iris, u)
|
|
}
|
|
|
|
return f.collectIRIs(ctx, iris)
|
|
}
|