mirrors/gotosocial
1
0
Fork 1
mirror of https://github.com/superseriousbusiness/gotosocial.git synced 2025-02-18 19:15:15 +00:00
Code Issues Projects Releases Packages Wiki Activity

[bugfix] Return 404 when web context target status hidden (#3792)

Browse source
This commit is contained in:
tobi 2025-02-13 14:10:13 +01:00 committed by GitHub
parent 24f6760c0e
commit dfcb7862a9
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 27 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

27
internal/processing/status/context.go
View file

@ -442,6 +442,33 @@ func (p *Processor) WebContextGet(
_, parentHidden := hiddenStatuses[status.InReplyToID]
v, err := p.visFilter.StatusVisible(ctx, nil, status)
if err != nil || !v || parentHidden {
// If this is the main status whose
// context we're looking for, and it's
// not visible for whatever reason, we
// should just return a 404 here, as we
// can't meaningfully render the thread.
if status.ID == targetStatusID {
var thisErr error
switch {
case err != nil:
thisErr = gtserror.Newf("error checking visibility of target status: %w", err)
case !v:
const errText = "target status not visible"
thisErr = gtserror.New(errText)
case parentHidden:
const errText = "target status parent is hidden"
thisErr = gtserror.New(errText)
}
return nil, gtserror.NewErrorNotFound(thisErr)
}
// This isn't the main status whose
// context we're looking for, just
// your standard not-visible status,
// so add it to the count + map.
if !inReplies {
// Main thread entry hidden.
wCtx.ThreadHidden++