small linter-related fixes

web/source/package.json

@@ -6,7 +6,7 @@
   "author": "f0x",
   "license": "AGPL-3.0",
   "scripts": {
-    "lint": "eslint .",
+    "lint": "eslint . --ext .js,.jsx",
     "build": "node index.js",
     "dev": "NODE_ENV=development node index.js"
   },
@@ -53,4 +53,4 @@
     "postcss-nested": "^6.0.0",
     "uglifyify": "^5.0.2"
   }
-}
+}

web/source/settings/admin/emoji/local/detail.js

@@ -80,8 +80,6 @@ function EmojiDetailForm({ data: emoji }) {
 		return <Redirect to={base} />;
 	}
 
-	console.log(form.category);
-
 	return (
 		<>
 			<div className="emoji-header">

web/source/settings/components/authorization/login.jsx

@@ -30,10 +30,7 @@ const Loading = require("../loading");
 module.exports = function Login({ }) {
 	const form = {
 		instance: useTextInput("instance", {
-			defaultValue: window.location.origin,
-			validator: (value) => {
-				return "";
-			}
+			defaultValue: window.location.origin
 		}),
 		scopes: useValue("scopes", "user admin")
 	};

web/source/settings/components/error.jsx

@@ -44,7 +44,8 @@ function ErrorFallback({ error, resetErrorBoundary }) {
 }
 
 function Error({ error }) {
-	console.error("Rendering:", error);
+	/* eslint-disable-next-line no-console */
+	console.error("Rendering error:", error);
 	let message;
 
 	if (error.data != undefined) { // RTK Query error with data

web/source/settings/components/form/mutation-button.jsx

@@ -25,9 +25,6 @@ module.exports = function MutationButton({ label, result, disabled, showError =
 	let iconClass = "";
 	const targetsThisButton = result.action == inputProps.name; // can also both be undefined, which is correct
 
-	/* FIXME? submitting an unchanged form will never transition to isLoading,
-		and check icon will stay faded out because the css animation doesn't restart
-	*/
 	if (targetsThisButton) {
 		if (result.isLoading) {
 			iconClass = "fa-spin fa-refresh";

web/source/settings/lib/form/check-list.jsx

@@ -59,7 +59,7 @@ function updateState(state, key, newValue) {
 	};
 }
 
-module.exports = function useCheckListInput({ name, Name }, { entries, uniqueKey = "key", defaultValue = false }) {
+module.exports = function useCheckListInput({ name }, { entries, uniqueKey = "key", defaultValue = false }) {
 	const [state, setState] = React.useState({});
 
 	const [someSelected, setSomeSelected] = React.useState(false);

web/source/settings/lib/query/admin/custom-emoji.js

@@ -151,7 +151,6 @@ module.exports = (build) => ({
 				}).then((res) => {
 					data.push([emoji.shortcode, res]);
 				}).catch((e) => {
-					console.error("emoji", action, "for", emoji.shortcode, "failed:", e);
 					let msg = e.message ?? e;
 					if (e.data.error) {
 						msg = e.data.error;

web/source/settings/lib/query/oauth.js

@@ -138,7 +138,6 @@ const endpoints = (build) => ({
 				url.searchParams.set("scope", app.scopes);
 
 				let redirectURL = url.toString();
-				console.log("OAUTH redirect to:", redirectURL);
 				window.location.assign(redirectURL);
 
 				return { data: null };