mirror of
https://codeberg.org/forgejo/forgejo.git
synced 2024-05-17 19:42:40 +00:00
de484e86bc
This PR adds the support for scopes of access tokens, mimicking the design of GitHub OAuth scopes. The changes of the core logic are in `models/auth` that `AccessToken` struct will have a `Scope` field. The normalized (no duplication of scope), comma-separated scope string will be stored in `access_token` table in the database. In `services/auth`, the scope will be stored in context, which will be used by `reqToken` middleware in API calls. Only OAuth2 tokens will have granular token scopes, while others like BasicAuth will default to scope `all`. A large amount of work happens in `routers/api/v1/api.go` and the corresponding `tests/integration` tests, that is adding necessary scopes to each of the API calls as they fit. - [x] Add `Scope` field to `AccessToken` - [x] Add access control to all API endpoints - [x] Update frontend & backend for when creating tokens - [x] Add a database migration for `scope` column (enable 'all' access to past tokens) I'm aiming to complete it before Gitea 1.19 release. Fixes #4300
89 lines
3.2 KiB
Go
89 lines
3.2 KiB
Go
// Copyright 2018 The Gitea Authors. All rights reserved.
|
|
// SPDX-License-Identifier: MIT
|
|
|
|
package integration
|
|
|
|
import (
|
|
"fmt"
|
|
"net/http"
|
|
"testing"
|
|
|
|
auth_model "code.gitea.io/gitea/models/auth"
|
|
repo_model "code.gitea.io/gitea/models/repo"
|
|
"code.gitea.io/gitea/models/unittest"
|
|
user_model "code.gitea.io/gitea/models/user"
|
|
"code.gitea.io/gitea/modules/git"
|
|
api "code.gitea.io/gitea/modules/structs"
|
|
"code.gitea.io/gitea/modules/util"
|
|
"code.gitea.io/gitea/tests"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
)
|
|
|
|
func TestAPIGitTags(t *testing.T) {
|
|
defer tests.PrepareTestEnv(t)()
|
|
user := unittest.AssertExistsAndLoadBean(t, &user_model.User{ID: 2})
|
|
repo := unittest.AssertExistsAndLoadBean(t, &repo_model.Repository{ID: 1})
|
|
// Login as User2.
|
|
session := loginUser(t, user.Name)
|
|
token := getTokenForLoggedInUser(t, session)
|
|
|
|
// Set up git config for the tagger
|
|
_ = git.NewCommand(git.DefaultContext, "config", "user.name").AddDynamicArguments(user.Name).Run(&git.RunOpts{Dir: repo.RepoPath()})
|
|
_ = git.NewCommand(git.DefaultContext, "config", "user.email").AddDynamicArguments(user.Email).Run(&git.RunOpts{Dir: repo.RepoPath()})
|
|
|
|
gitRepo, _ := git.OpenRepository(git.DefaultContext, repo.RepoPath())
|
|
defer gitRepo.Close()
|
|
|
|
commit, _ := gitRepo.GetBranchCommit("master")
|
|
lTagName := "lightweightTag"
|
|
gitRepo.CreateTag(lTagName, commit.ID.String())
|
|
|
|
aTagName := "annotatedTag"
|
|
aTagMessage := "my annotated message"
|
|
gitRepo.CreateAnnotatedTag(aTagName, aTagMessage, commit.ID.String())
|
|
aTag, _ := gitRepo.GetTag(aTagName)
|
|
|
|
// SHOULD work for annotated tags
|
|
req := NewRequestf(t, "GET", "/api/v1/repos/%s/%s/git/tags/%s?token=%s", user.Name, repo.Name, aTag.ID.String(), token)
|
|
res := MakeRequest(t, req, http.StatusOK)
|
|
|
|
var tag *api.AnnotatedTag
|
|
DecodeJSON(t, res, &tag)
|
|
|
|
assert.Equal(t, aTagName, tag.Tag)
|
|
assert.Equal(t, aTag.ID.String(), tag.SHA)
|
|
assert.Equal(t, commit.ID.String(), tag.Object.SHA)
|
|
assert.Equal(t, aTagMessage+"\n", tag.Message)
|
|
assert.Equal(t, user.Name, tag.Tagger.Name)
|
|
assert.Equal(t, user.Email, tag.Tagger.Email)
|
|
assert.Equal(t, util.URLJoin(repo.APIURL(), "git/tags", aTag.ID.String()), tag.URL)
|
|
|
|
// Should NOT work for lightweight tags
|
|
badReq := NewRequestf(t, "GET", "/api/v1/repos/%s/%s/git/tags/%s?token=%s", user.Name, repo.Name, commit.ID.String(), token)
|
|
MakeRequest(t, badReq, http.StatusBadRequest)
|
|
}
|
|
|
|
func TestAPIDeleteTagByName(t *testing.T) {
|
|
defer tests.PrepareTestEnv(t)()
|
|
|
|
repo := unittest.AssertExistsAndLoadBean(t, &repo_model.Repository{ID: 1})
|
|
owner := unittest.AssertExistsAndLoadBean(t, &user_model.User{ID: repo.OwnerID})
|
|
session := loginUser(t, owner.LowerName)
|
|
token := getTokenForLoggedInUser(t, session, auth_model.AccessTokenScopeRepo)
|
|
|
|
urlStr := fmt.Sprintf("/api/v1/repos/%s/%s/tags/delete-tag?token=%s",
|
|
owner.Name, repo.Name, token)
|
|
|
|
req := NewRequestf(t, http.MethodDelete, urlStr)
|
|
_ = MakeRequest(t, req, http.StatusNoContent)
|
|
|
|
// Make sure that actual releases can't be deleted outright
|
|
createNewReleaseUsingAPI(t, session, token, owner, repo, "release-tag", "", "Release Tag", "test")
|
|
urlStr = fmt.Sprintf("/api/v1/repos/%s/%s/tags/release-tag?token=%s",
|
|
owner.Name, repo.Name, token)
|
|
|
|
req = NewRequestf(t, http.MethodDelete, urlStr)
|
|
_ = MakeRequest(t, req, http.StatusConflict)
|
|
}
|