forgejo/services
Lunny Xiao ca67c5a8a7
refactor auth interface to return error when verify failure (#22119)
This PR changed the Auth interface signature from 
`Verify(http *http.Request, w http.ResponseWriter, store DataStore, sess
SessionStore) *user_model.User`
to 
`Verify(http *http.Request, w http.ResponseWriter, store DataStore, sess
SessionStore) (*user_model.User, error)`.

There is a new return argument `error` which means the verification
condition matched but verify process failed, we should stop the auth
process.

Before this PR, when return a `nil` user, we don't know the reason why
it returned `nil`. If the match condition is not satisfied or it
verified failure? For these two different results, we should have
different handler. If the match condition is not satisfied, we should
try next auth method and if there is no more auth method, it's an
anonymous user. If the condition matched but verify failed, the auth
process should be stop and return immediately.

This will fix #20563

Co-authored-by: KN4CK3R <admin@oldschoolhack.me>
Co-authored-by: Jason Song <i@wolfogre.com>
2022-12-28 13:53:28 +08:00
..
agit Rename almost all Ctx functions (#22071) 2022-12-10 10:46:31 +08:00
asymkey Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
attachment Add API management for issue/pull and comment attachments (#21783) 2022-12-09 14:35:56 +08:00
auth refactor auth interface to return error when verify failure (#22119) 2022-12-28 13:53:28 +08:00
automerge refactor some functions to support ctx as first parameter (#21878) 2022-12-03 10:48:26 +08:00
context Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
cron Add doctor command for full GC of LFS (#21978) 2022-12-15 20:44:16 +00:00
externalaccount Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
forms Secrets storage with SecretKey encrypted (#22142) 2022-12-20 17:07:13 +08:00
gitdiff Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
issue Rename almost all Ctx functions (#22071) 2022-12-10 10:46:31 +08:00
lfs refactor some functions to support ctx as first parameter (#21878) 2022-12-03 10:48:26 +08:00
mailer refactor some functions to support ctx as first parameter (#21878) 2022-12-03 10:48:26 +08:00
markup Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
migrations Check primary keys for all tables and drop ForeignReference (#21721) 2022-12-23 19:35:43 +08:00
mirror Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
org Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
packages refactor auth interface to return error when verify failure (#22119) 2022-12-28 13:53:28 +08:00
pull Use complete SHA to create and query commit status (#22244) 2022-12-27 21:12:49 +08:00
release Add API management for issue/pull and comment attachments (#21783) 2022-12-09 14:35:56 +08:00
repository Add option to prohibit fork if user reached maximum limit of repositories (#21848) 2022-12-27 15:21:14 -06:00
task Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
user Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
webhook Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
wiki Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00