forgejo/models/actions
Giteabot 1543ac9c8d
Fix missing commit status in PR which from forked repo (#23351) (#23453)
Backport #23351 by @sillyguodong

close: #23347

### Reference and Inference
According to Github REST API
[doc](https://docs.github.com/en/rest/commits/statuses?apiVersion=2022-11-28#list-commit-statuses-for-a-reference):
1. The `Drone CI` that can create some commit status by
[API](https://docs.github.com/en/rest/commits/statuses?apiVersion=2022-11-28#create-a-commit-status)
is enabled in `go-gitea/gitea`. So I tried to call the API to get a
commit status list of a PR which is commited to upstream
repo(`go-gitea/gitea`). As a result, the API returned a array of commit
status.

![image](https://user-images.githubusercontent.com/33891828/223913371-313d047a-5e2e-484c-b13e-dcd38748703e.png)
2. Then I tried to call the API to get commit status list of the
reference which of the `SHA` is the same as step 1 in the repo which is
forked from `go-gitea/gitea`. But I got a empty array.

![image](https://user-images.githubusercontent.com/33891828/223930827-17a64d3c-f466-4980-897c-77fe386c4d3b.png)

So, I believe it that:
1. The commit status is not shared between upstream repo and forked
repo.
2. The coomit status is bound to a repo that performs actions. (Gitea's
logic is the same)

### Cause
During debugging, I found it that commit status are not stored in the DB
as expected.
So, I located the following code:

8cadd51bf2/services/actions/commit_status.go (L18-L26)
When I create a PR, the type of `event` is `pull request`, not `push`.
So the code return function directly.

### Screenshot

![image](https://user-images.githubusercontent.com/33891828/223939339-dadf539c-1fdd-40c4-96e9-2e4fa733f531.png)

![image](https://user-images.githubusercontent.com/33891828/223939519-edb02bf0-2478-4ea5-9366-be85468f02db.png)

![image](https://user-images.githubusercontent.com/33891828/223939557-ec6f1375-5536-400e-8987-fb7d2fd452fa.png)

### Other 
In this PR, I also fix the problem of missing icon which represents
running in PRs list.

![image](https://user-images.githubusercontent.com/33891828/223939898-2a0339e4-713f-4c7b-9d99-2250a43f3457.png)

![image](https://user-images.githubusercontent.com/33891828/223939979-037a975f-5ced-480c-bac7-0ee00ebfff4b.png)

Co-authored-by: sillyguodong <33891828+sillyguodong@users.noreply.github.com>
2023-03-14 08:11:31 +08:00
..
run.go Fix missing commit status in PR which from forked repo (#23351) (#23453) 2023-03-14 08:11:31 +08:00
run_job.go Implement actions (#21937) 2023-01-31 09:45:19 +08:00
run_job_list.go Implement actions (#21937) 2023-01-31 09:45:19 +08:00
run_list.go Implement actions (#21937) 2023-01-31 09:45:19 +08:00
runner.go Implement actions (#21937) 2023-01-31 09:45:19 +08:00
runner_list.go Implement actions (#21937) 2023-01-31 09:45:19 +08:00
runner_token.go Implement actions (#21937) 2023-01-31 09:45:19 +08:00
status.go Implement actions (#21937) 2023-01-31 09:45:19 +08:00
task.go Avoid too long names for actions (#23162) (#23190) 2023-02-28 13:42:40 +01:00
task_list.go Implement actions (#21937) 2023-01-31 09:45:19 +08:00
task_step.go Implement actions (#21937) 2023-01-31 09:45:19 +08:00
utils.go Implement actions (#21937) 2023-01-31 09:45:19 +08:00
utils_test.go Implement actions (#21937) 2023-01-31 09:45:19 +08:00