Beyond coding. We forge. (Code of Conduct: https://codeberg.org/forgejo/code-of-conduct)
Go to file
Richard Mahn 98f7013756
Prevent NPE in CSV diff rendering when column removed (#17018)
Fixes #16837 if a column is deleted.

We were clobbering the columns that were added by looping through the aline (base) and then when bline (head) was looped through, it clobbered what was in the "cells" array that is show in the diff, and then left a nil cell because nothing was shifted.

This fix properly shifts the cells, and properly puts the b cell either at its location or after, according to what the aline placed in the cells.

This includes test, adding a new test function since adding/removing cells works best with three columns, not two, which results in 4 columns of the resulting cells because it has a deleted column and an added column. If you try this locally, you can try those cases and others, such as adding a column.

There was no need to do anything special for the rows when `aline == 0 || bline == 0` so that was removed. This allows the same code to be used for removed or added lines, with the bcell text always being the RightCell, acell text being the LeftCell.

I still added the patch zeripath gave at https://github.com/go-gitea/gitea/issues/16837#issuecomment-913007382 so that just in case for some reason a cell is nil (which shouldn't happen now) it doesn't throw a 500 error, so the user can at least view the raw diff.

Also fixes in the [view.go](https://github.com/go-gitea/gitea/pull/17018/files#diff-43a7f4747c7ba8bff888c9be11affaafd595fd55d27f3333840eb19df9fad393L521) file how if a CSV file is empty (either created empty or if you edit it and remove all contents) it throws a huge 500 error when you then save it (when you view the file). Since we allow creating, saving and pushing empty files, we shouldn't throw an error on an empty CSV file, but just show its empty contents. This doesn't happen if it is a Markdown file or other type of file that is empty.
EDIT: Now handled in the markup/csv renderer code
2021-10-20 20:10:03 +01:00
.gitea Issue template form (#16349) 2021-09-15 20:33:13 +03:00
.github Fix wording in issue template (#17176) 2021-09-29 13:03:44 +02:00
assets Clean up SVG (#13680) 2020-12-17 16:33:53 -05:00
build refactor: move from io/ioutil to io and os package (#17109) 2021-09-22 13:38:34 +08:00
cmd Use a variable but a function for IsProd because of a slight performance increment (#17368) 2021-10-20 16:37:19 +02:00
contrib Move login related structs and functions to models/login (#17093) 2021-09-24 19:32:56 +08:00
custom/conf Make the Mirror Queue a queue (#17326) 2021-10-17 12:43:25 +01:00
docker Change docker tag logic (#16421) 2021-07-14 18:08:43 +01:00
docs docs: add permission notes to SSH Container Passthrough (#17347) 2021-10-18 12:26:47 -04:00
integrations api: integration test for nodeinfo (#17346) 2021-10-18 01:36:56 -04:00
models Use a variable but a function for IsProd because of a slight performance increment (#17368) 2021-10-20 16:37:19 +02:00
modules Prevent NPE in CSV diff rendering when column removed (#17018) 2021-10-20 20:10:03 +01:00
options "Copy branch name" button in pull request (#17323) 2021-10-19 13:32:11 -04:00
public Update JS dependencies (#17357) 2021-10-19 15:23:58 +08:00
routers Use a variable but a function for IsProd because of a slight performance increment (#17368) 2021-10-20 16:37:19 +02:00
services Prevent NPE in CSV diff rendering when column removed (#17018) 2021-10-20 20:10:03 +01:00
snap Removable media support (#16136) 2021-06-11 14:51:05 -04:00
templates Prevent NPE in CSV diff rendering when column removed (#17018) 2021-10-20 20:10:03 +01:00
tools Add bundle download for repository (#14538) 2021-08-24 11:47:09 -05:00
vendor Add RSS/Atom feed support for user actions (#16002) 2021-10-16 16:21:16 +02:00
web_src Prevent NPE in CSV diff rendering when column removed (#17018) 2021-10-20 20:10:03 +01:00
.air.toml Rename .air.conf to .air.toml (#17360) 2021-10-20 00:27:29 +08:00
.changelog.yml Changelog for v1.15.0-rc1 (#16422) 2021-07-15 11:47:57 -04:00
.drone.yml Add protection to disable Gitea when run as root (#17168) 2021-10-07 10:52:08 +02:00
.editorconfig add well-known config for OIDC (#15355) 2021-04-15 22:32:00 -04:00
.eslintrc Update JS dependencies (#17357) 2021-10-19 15:23:58 +08:00
.gitattributes Remove unused Fomantic sidebar module (#16853) 2021-08-29 21:57:07 +02:00
.gitignore Frontend refactor: move Vue related code from index.js to components dir, and remove unused codes. (#17301) 2021-10-15 10:35:26 +08:00
.golangci.yml Move login related structs and functions to models/login (#17093) 2021-09-24 19:32:56 +08:00
.ignore Fonts rework (#12114) 2020-07-06 11:56:54 +03:00
.lgtm refactor: ignore LGTM from author of pull request. (#3283) 2018-01-02 06:13:49 -06:00
.npmrc Stop packaging node_modules in release tarballs (#15273) 2021-04-09 01:08:14 -04:00
.revive.toml refactor: replace lint to revive (#5422) 2018-12-03 09:28:46 -05:00
.stylelintrc Use light/dark theme based on system preference (#17051) 2021-09-27 15:47:44 +01:00
BSDmakefile Add BSDmakefile to prevent errors when make is called under FreeBSD (#4446) 2018-07-16 20:45:51 +02:00
build.go Add bundle download for repository (#14538) 2021-08-24 11:47:09 -05:00
CHANGELOG.md changelog for 1.15.4 (frontport) (#17273) 2021-10-08 22:51:57 +01:00
CONTRIBUTING.md [API] generalize list header (#16551) 2021-08-12 14:43:08 +02:00
DCO follow the advisor: add DCO and some improvements 2016-11-04 16:43:41 +08:00
Dockerfile build with go1.17 (#16707) 2021-08-17 08:31:28 -04:00
Dockerfile.rootless build with go1.17 (#16707) 2021-08-17 08:31:28 -04:00
go.mod Add RSS/Atom feed support for user actions (#16002) 2021-10-16 16:21:16 +02:00
go.sum Add RSS/Atom feed support for user actions (#16002) 2021-10-16 16:21:16 +02:00
jest.config.js Update JS dependencies (#17357) 2021-10-19 15:23:58 +08:00
LICENSE Fix typo 2016-11-08 08:42:05 +01:00
main.go Dump github/gitlab/gitea repository data to a local directory and restore to gitea (#12244) 2020-12-27 11:34:19 +08:00
MAINTAINERS Add delvh to MAINTAINERS (#17170) 2021-09-28 14:28:12 +02:00
Makefile Rename .air.conf to .air.toml (#17360) 2021-10-20 00:27:29 +08:00
package-lock.json Update JS dependencies (#17357) 2021-10-19 15:23:58 +08:00
package.json Update JS dependencies (#17357) 2021-10-19 15:23:58 +08:00
README.md Fix report card link (#16885) 2021-08-31 01:06:30 +02:00
README_ZH.md Fix report card link (#16885) 2021-08-31 01:06:30 +02:00
SECURITY.md Add security policy to repo (#12536) 2020-08-19 17:15:55 +01:00
webpack.config.js Update JS dependencies (#17357) 2021-10-19 15:23:58 +08:00

Gitea

Gitea - Git with a cup of tea

View the chinese version of this document

Purpose

The goal of this project is to make the easiest, fastest, and most painless way of setting up a self-hosted Git service. Using Go, this can be done with an independent binary distribution across all platforms which Go supports, including Linux, macOS, and Windows on x86, amd64, ARM and PowerPC architectures. Want to try it before doing anything else? Do it with the online demo! This project has been forked from Gogs since 2016.11 but changed a lot.

Building

From the root of the source tree, run:

TAGS="bindata" make build

or if sqlite support is required:

TAGS="bindata sqlite sqlite_unlock_notify" make build

The build target is split into two sub-targets:

  • make backend which requires Go 1.16 or greater.
  • make frontend which requires Node.js 12.17 or greater and Internet connectivity to download npm dependencies.

When building from the official source tarballs which include pre-built frontend files, the frontend target will not be triggered, making it possible to build without Node.js and Internet connectivity.

Parallelism (make -j <num>) is not supported.

More info: https://docs.gitea.io/en-us/install-from-source/

Using

./gitea web

NOTE: If you're interested in using our APIs, we have experimental support with documentation.

Contributing

Expected workflow is: Fork -> Patch -> Push -> Pull Request

NOTES:

  1. YOU MUST READ THE CONTRIBUTORS GUIDE BEFORE STARTING TO WORK ON A PULL REQUEST.
  2. If you have found a vulnerability in the project, please write privately to security@gitea.io. Thanks!

Translating

Translations are done through Crowdin. If you want to translate to a new language ask one of the managers in the Crowdin project to add a new language there.

You can also just create an issue for adding a language or ask on discord on the #translation channel. If you need context or find some translation issues, you can leave a comment on the string or ask on Discord. For general translation questions there is a section in the docs. Currently a bit empty but we hope fo fill it as questions pop up.

https://docs.gitea.io/en-us/translation-guidelines/

Crowdin

Further information

For more information and instructions about how to install Gitea, please look at our documentation. If you have questions that are not covered by the documentation, you can get in contact with us on our Discord server or create a post in the discourse forum.

We maintain a list of Gitea-related projects at gitea/awesome-gitea.
The hugo-based documentation theme is hosted at gitea/theme.
The official Gitea CLI is developed at gitea/tea.

Authors

Backers

Thank you to all our backers! 🙏 [Become a backer]

Sponsors

Support this project by becoming a sponsor. Your logo will show up here with a link to your website. [Become a sponsor]

FAQ

How do you pronounce Gitea?

Gitea is pronounced /ɡɪti:/ as in "gi-tea" with a hard g.

Why is this not hosted on a Gitea instance?

We're working on it.

License

This project is licensed under the MIT License. See the LICENSE file for the full license text.

Screenshots

Looking for an overview of the interface? Check it out!

Dashboard User Profile Global Issues
Branches Web Editor Activity
New Migration Migrating Pull Request View
Pull Request Dark Diff Review Dark Diff Dark