forgejo/modules
mrsdizzie 8d99ee2773
Add Organization Wide Labels (#10814)
* Add organization wide labels

Implement organization wide labels similar to organization wide
webhooks. This lets you create individual labels for organizations that can be used
for all repos under that organization (so being able to reuse the same
label across multiple repos).

This makes it possible for small organizations with many repos to use
labels effectively.

Fixes #7406

* Add migration

* remove comments

* fix tests

* Update options/locale/locale_en-US.ini

Removed unused translation string

* show org labels in issue search label filter

* Use more clear var name

* rename migration after merge from master

* comment typo

* update migration again after rebase with master

* check for orgID <=0 per guillep2k review

* fmt

* Apply suggestions from code review

Co-Authored-By: guillep2k <18600385+guillep2k@users.noreply.github.com>

* remove unused code

* Make sure RepoID is 0 when searching orgID per code review

* more changes/code review requests

* More descriptive translation var per code review

* func description/delete comment when issue label deleted instead of hiding it

* remove comment

* only use issues in that repo when calculating number of open issues for org label on repo label page

* Add integration test for IssuesSearch API with labels

* remove unused function

* Update models/issue_label.go

Co-Authored-By: guillep2k <18600385+guillep2k@users.noreply.github.com>

* Use subquery in GetLabelIDsInReposByNames

* Fix tests to use correct orgID

* fix more tests

* IssuesSearch api now uses new BuildLabelNamesIssueIDsCondition. Add a few more tests as well

* update comment for clarity

* Revert previous code change now that we can use the new BuildLabelNamesIssueIDsCondition

* Don't sort repos by date in IssuesSearch API

After much debugging I've found a strange issue where in some cases MySQL will return a different result than other enigines if a query is sorted by a null collumn. For example with our integration test data where we don't set updated_unix in repository fixtures:

SELECT `id`, `owner_id`, `owner_name`, `lower_name`, `name`, `description`, `website`, `original_service_type`, `original_url`, `default_branch`, `num_watches`, `num_stars`, `num_forks`, `num_issues`, `num_closed_issues`, `num_pulls`, `num_closed_pulls`, `num_milestones`, `num_closed_milestones`, `is_private`, `is_empty`, `is_archived`, `is_mirror`, `status`, `is_fork`, `fork_id`, `is_template`, `template_id`, `size`, `is_fsck_enabled`, `close_issues_via_commit_in_any_branch`, `topics`, `avatar`, `created_unix`, `updated_unix` FROM `repository` ORDER BY updated_unix DESC LIMIT 15 OFFSET 45

Returns different results for MySQL than other engines. However, the similar query:

SELECT `id`, `owner_id`, `owner_name`, `lower_name`, `name`, `description`, `website`, `original_service_type`, `original_url`, `default_branch`, `num_watches`, `num_stars`, `num_forks`, `num_issues`, `num_closed_issues`, `num_pulls`, `num_closed_pulls`, `num_milestones`, `num_closed_milestones`, `is_private`, `is_empty`, `is_archived`, `is_mirror`, `status`, `is_fork`, `fork_id`, `is_template`, `template_id`, `size`, `is_fsck_enabled`, `close_issues_via_commit_in_any_branch`, `topics`, `avatar`, `created_unix`, `updated_unix` FROM `repository` ORDER BY updated_unix DESC LIMIT 15 OFFSET 30

Returns the same results.

This causes integration tests to fail on MySQL in certain cases but would never show up in a real installation. Since this API call always returns issues based on the optionally provided repo_priority_id or the issueID itself, there is no change to results by changing the repo sorting method used to get ids earlier in the function.

* linter is back!

* code review

* remove now unused option

* Fix newline at end of files

* more unused code

* update to master

* check for matching ids before query

* Update models/issue_label.go

Co-Authored-By: 6543 <6543@obermui.de>

* Update models/issue_label.go

* update comments

* Update routers/org/setting.go

Co-authored-by: Lauris BH <lauris@nix.lv>
Co-authored-by: guillep2k <18600385+guillep2k@users.noreply.github.com>
Co-authored-by: 6543 <6543@obermui.de>
2020-04-01 01:14:46 -03:00
..
analyze Add detected file language to code search (#10256) 2020-02-20 16:53:55 -03:00
auth Add Matrix webhook (#10831) 2020-03-28 15:09:55 +02:00
avatar Improve handling of non-square avatars (#7025) 2019-05-25 14:46:14 +03:00
base make avatar lookup occur at image request (#10540) 2020-03-27 14:34:39 +02:00
cache make avatar lookup occur at image request (#10540) 2020-03-27 14:34:39 +02:00
charset deps: update and fix chardet import (#9351) 2019-12-14 02:15:48 +02:00
context API add/generalize pagination (#9452) 2020-01-24 14:00:29 -05:00
convert Allow to set protected file patterns that can not be changed under no conditions (#10806) 2020-03-27 00:26:34 +02:00
cron Refactor repository check and sync functions (#9854) 2020-01-20 20:01:19 +00:00
generate Integrate OAuth2 Provider (#5378) 2019-03-08 11:42:50 -05:00
git Convert plumbing.ErrObjectNotFound to git.ErrNotExist in getCommit (#10862) 2020-03-28 20:59:21 +02:00
gitgraph Move git graph from models to modules/graph (#9027) 2019-11-16 08:47:57 +08:00
graceful Restore graceful restart on SIGHUP (#10224) 2020-02-11 13:29:45 +08:00
highlight Add a lot of extension to language mappings for syntax highlights (#7741) 2019-08-05 23:48:31 +08:00
httplib Add golangci (#6418) 2019-06-12 15:41:28 -04:00
indexer Handle panic in indexer initialisation better (#10534) 2020-02-28 22:00:09 +00:00
lfs Multiple LFS improvements (#10667) 2020-03-09 19:56:18 +00:00
log modules/log: remove noop written variables (#10182) 2020-02-07 21:35:30 +01:00
markup Fix internal server error on checkboxes (#10845) 2020-03-26 23:47:34 +00:00
metrics Prometheus endpoint (#5256) 2018-11-04 22:20:00 -05:00
migrations Some refactor on git diff and ignore getting commit information failed on migrating pull request review comments (#9996) 2020-01-28 08:02:03 +00:00
notification Granular webhook events (#9626) 2020-03-06 07:10:48 +02:00
options Implement "embedded" command to extract static resources (#9982) 2020-02-02 10:17:44 +08:00
password Add password requirement info on error (#9074) 2019-11-19 22:44:58 +00:00
pprof Add golangci (#6418) 2019-06-12 15:41:28 -04:00
private Upgrade golangci-lint to 1.24.0 (#10894) 2020-03-30 21:52:45 +03:00
process Graceful: Cancel Process on monitor pages & HammerTime (#9213) 2019-11-30 16:40:22 +02:00
public Implement "embedded" command to extract static resources (#9982) 2020-02-02 10:17:44 +08:00
queue Avoid logging []byte in queue failures - convert to string first (#10865) 2020-03-29 15:12:15 +08:00
recaptcha fixed reCAPTCHA URL (#9083) 2019-11-22 08:03:45 +00:00
references Accept punctuation after simple+cross repository issue references (#10091) 2020-02-01 18:01:30 +00:00
repofiles Handle push rejection in branch and upload (#10854) 2020-03-28 01:13:18 -03:00
repository Add Organization Wide Labels (#10814) 2020-04-01 01:14:46 -03:00
secret Integrate OAuth2 Provider (#5378) 2019-03-08 11:42:50 -05:00
session Use gitea forked macaron (#7933) 2019-08-23 12:40:29 -04:00
setting Add Matrix webhook (#10831) 2020-03-28 15:09:55 +02:00
ssh log.Fatal on failure to listen to SSH port (#10795) 2020-03-23 07:59:38 +00:00
structs Allow to set protected file patterns that can not be changed under no conditions (#10806) 2020-03-27 00:26:34 +02:00
sync Fix missing unlock in uniquequeue (#9790) 2020-01-15 23:58:33 +02:00
task Move create/fork repository from models to modules/repository (#9489) 2020-01-12 20:11:17 +08:00
templates make avatar lookup occur at image request (#10540) 2020-03-27 14:34:39 +02:00
test Add Organization Wide Labels (#10814) 2020-04-01 01:14:46 -03:00
timeutil Use gitea forked macaron (#7933) 2019-08-23 12:40:29 -04:00
upload Fix upload file type check (#7890) 2019-08-17 13:10:17 +03:00
user Add golangci (#6418) 2019-06-12 15:41:28 -04:00
util inform participants on UI too (#10473) 2020-02-28 05:16:41 -03:00
validation Implement webhook branch filter (#7791) 2019-09-09 08:48:21 +03:00
webhook Add Matrix webhook (#10831) 2020-03-28 15:09:55 +02:00