mirror of
https://codeberg.org/forgejo/forgejo.git
synced 2024-05-20 09:18:34 +00:00
81fe5d6185
This improves a lot of accessibility shortcomings. Every possible instance of `<div class="button">` matching the command `ag '<[^ab].*?class=.*?[" ]button[ "]' templates/ | grep -v 'dropdown'` has been converted when possible. divs with the `dropdown` class and their children were omitted as 1. more analysis must be conducted whether the dropdowns still work as intended when they are a `button` instead of a `div`. 2. most dropdowns have `div`s as children. The HTML standard disallows `div`s inside `button`s. 3. When a dropdown child that's part of the displayed text content is converted to a `button`, the dropdown can be focused twice Further changes include that all "gitea-managed" buttons with JS code received an `e.preventDefault()` so that they don't accidentally submit an underlying form, which would execute instead of cancel the action. Lastly, some minor issues were fixed as well during the refactoring. ## Future improvements As mentioned in https://github.com/go-gitea/gitea/pull/23337#discussion_r1127277391, `<a>`s without `href` attribute are not focusable. They should later on be converted to `<button>`s. --------- Co-authored-by: wxiaoguang <wxiaoguang@gmail.com> Co-authored-by: silverwind <me@silverwind.io> Co-authored-by: techknowlogick <techknowlogick@gitea.io> Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
65 lines
2.3 KiB
Handlebars
65 lines
2.3 KiB
Handlebars
<div class="ui small basic delete modal">
|
|
<div class="ui icon header">
|
|
{{svg "octicon-trash"}}
|
|
{{.locale.Tr "repo.issues.label_deletion"}}
|
|
</div>
|
|
<div class="content">
|
|
<p>{{.locale.Tr "repo.issues.label_deletion_desc"}}</p>
|
|
</div>
|
|
{{template "base/delete_modal_actions" .}}
|
|
</div>
|
|
|
|
<div class="ui small edit-label modal">
|
|
<div class="header">
|
|
{{.locale.Tr "repo.issues.label_modify"}}
|
|
</div>
|
|
<div class="content">
|
|
<form class="ui edit-label form ignore-dirty" action="{{$.Link}}/edit" method="post">
|
|
{{.CsrfTokenHtml}}
|
|
<input id="label-modal-id" name="id" type="hidden">
|
|
<div class="required field">
|
|
<label for="name">{{.locale.Tr "repo.issues.label_title"}}</label>
|
|
<div class="ui small input">
|
|
<input class="label-name-input emoji-input" name="title" placeholder="{{.locale.Tr "repo.issues.new_label_placeholder"}}" autofocus required maxlength="50">
|
|
</div>
|
|
</div>
|
|
<div class="field label-exclusive-input-field">
|
|
<div class="ui checkbox">
|
|
<input class="label-exclusive-input" name="exclusive" type="checkbox">
|
|
<label>{{.locale.Tr "repo.issues.label_exclusive"}}</label>
|
|
</div>
|
|
<br/>
|
|
<small class="desc">{{.locale.Tr "repo.issues.label_exclusive_desc" | Safe}}</small>
|
|
<div class="desc gt-ml-2 gt-mt-3 gt-hidden label-exclusive-warning">
|
|
{{svg "octicon-alert"}} {{.locale.Tr "repo.issues.label_exclusive_warning" | Safe}}
|
|
</div>
|
|
</div>
|
|
<div class="field">
|
|
<label for="description">{{.locale.Tr "repo.issues.label_description"}}</label>
|
|
<div class="ui small fluid input">
|
|
<input class="label-desc-input" name="description" placeholder="{{.locale.Tr "repo.issues.new_label_desc_placeholder"}}" maxlength="200">
|
|
</div>
|
|
</div>
|
|
<div class="field color-field">
|
|
<label for="color">{{$.locale.Tr "repo.issues.label_color"}}</label>
|
|
<div class="color picker column">
|
|
<input class="color-picker" name="color" value="#70c24a" required maxlength="7">
|
|
<div class="column precolors">
|
|
{{template "repo/issue/label_precolors"}}
|
|
</div>
|
|
</div>
|
|
</div>
|
|
</form>
|
|
</div>
|
|
<div class="actions">
|
|
<button class="ui secondary small basic cancel button">
|
|
{{svg "octicon-x"}}
|
|
{{.locale.Tr "cancel"}}
|
|
</button>
|
|
<button class="ui primary small approve button">
|
|
<i class="save icon"></i>
|
|
{{.locale.Tr "save"}}
|
|
</button>
|
|
</div>
|
|
</div>
|