mirrors/forgejo
1
0
Fork 0
mirror of https://codeberg.org/forgejo/forgejo.git synced 2024-11-15 22:01:08 +00:00
Code Issues Projects Releases Packages Wiki Activity
forgejo/tests
History
KN4CK3R 5f79550a0d
Prevent double use of git cat-file session. (#29298) 
Fixes the reason why #29101 is hard to replicate.
Related #29297

Create a repo with a file with minimum size 4097 bytes (I use 10000) and
execute the following code:
```go
gitRepo, err := gitrepo.OpenRepository(db.DefaultContext, <repo>)
assert.NoError(t, err)

commit, err := gitRepo.GetCommit(<sha>)
assert.NoError(t, err)

entry, err := commit.GetTreeEntryByPath(<file>)
assert.NoError(t, err)

b := entry.Blob()

// Create a reader
r, err := b.DataAsync()
assert.NoError(t, err)
defer r.Close()

// Create a second reader
r2, err := b.DataAsync()
assert.NoError(t, err) // Should be no error but is ErrNotExist
defer r2.Close()
```

The problem is the check in `CatFileBatch`:

79217ea63c/modules/git/repo_base_nogogit.go (L81-L87)
`Buffered() > 0` is used to check if there is a "operation" in progress
at the moment. This is a problem because we can't control the internal
buffer in the `bufio.Reader`. The code above demonstrates a sequence
which initiates an operation for which the code thinks there is no
active processing. The second call to `DataAsync()` therefore reuses the
existing instances instead of creating a new batch reader.

(cherry picked from commit f74c869221624092999097af38b6f7fae4701420)
2024-02-26 22:30:25 +01:00
..
e2e Add e2e debug server 2024-02-21 20:47:57 +01:00
fuzz Rework markup link rendering (#26745) 2024-01-15 08:49:24 +00:00
gitea-lfs-meta
gitea-repositories-meta [GITEA] Detect file rename and show in history 2024-02-05 16:09:40 +01:00
integration Prevent double use of git cat-file session. (#29298) 2024-02-26 22:30:25 +01:00
testdata/data/attachments/a/0
mssql.ini.tmpl [CI] Forgejo Actions based CI (squash) all queues are immediate 2024-02-05 13:33:59 +01:00
mysql.ini.tmpl [CI] Forgejo Actions based CI (squash) all queues are immediate 2024-02-05 13:33:59 +01:00
pgsql.ini.tmpl [CI] Forgejo Actions based CI (squash) all queues are immediate 2024-02-05 13:33:59 +01:00
sqlite.ini.tmpl [TESTS] increase test-sqlite log level to Trace 2024-02-05 14:44:33 +01:00
test_utils.go [TESTS] tests.AddFixtures helper loads additional per-test fixtures 2024-02-05 14:44:33 +01:00