forgejo/modules
zeripath 5d2e11eedb
Refactor: Move login out of models (#16199)
`models` does far too much. In particular it handles all `UserSignin`.

It shouldn't be responsible for calling LDAP, SMTP or PAM for signing in.

Therefore we should move this code out of `models`.

This code has to depend on `models` - therefore it belongs in `services`.

There is a package in `services` called `auth` and clearly this functionality belongs in there.

Plan:

- [x] Change `auth.Auth` to `auth.Method` - as they represent methods of authentication.
- [x] Move `models.UserSignIn` into `auth`
- [x] Move `models.ExternalUserLogin`
- [x] Move most of the `LoginVia*` methods to `auth` or subpackages
- [x] Move Resynchronize functionality to `auth`
  - Involved some restructuring of `models/ssh_key.go` to reduce the size of this massive file and simplify its files.
- [x] Move the rest of the LDAP functionality in to the ldap subpackage
- [x] Re-factor the login sources to express an interfaces `auth.Source`?
  - I've done this through some smaller interfaces Authenticator and Synchronizable - which would allow us to extend things in future
- [x] Now LDAP is out of models - need to think about modules/auth/ldap and I think all of that functionality might just be moveable
- [x] Similarly a lot Oauth2 functionality need not be in models too and should be moved to services/auth/source/oauth2
  - [x] modules/auth/oauth2/oauth2.go uses xorm... This is naughty - probably need to move this into models.
  - [x] models/oauth2.go - mostly should be in modules/auth/oauth2 or services/auth/source/oauth2 
- [x] More simplifications of login_source.go may need to be done
- Allow wiring in of notify registration -  *this can now easily be done - but I think we should do it in another PR*  - see #16178 
- More refactors...?
  - OpenID should probably become an auth Method but I think that can be left for another PR
  - Methods should also probably be cleaned up  - again another PR I think.
  - SSPI still needs more refactors.* Rename auth.Auth auth.Method
* Restructure ssh_key.go

- move functions from models/user.go that relate to ssh_key to ssh_key
- split ssh_key.go to try create clearer function domains for allow for
future refactors here.

Signed-off-by: Andrew Thornton <art27@cantab.net>
2021-07-24 11:16:34 +01:00
..
analyze Speed up enry.IsVendor (#15213) 2021-04-01 19:41:09 +02:00
auth Refactor: Move login out of models (#16199) 2021-07-24 11:16:34 +01:00
avatar Add Image Diff for SVG files (#14867) 2021-06-05 15:32:19 +03:00
base Fixed assert statements. (#16089) 2021-06-07 07:27:09 +02:00
cache Add LRU mem cache implementation (#16226) 2021-07-10 23:54:15 +02:00
charset Refactor renders (#15175) 2021-04-19 18:25:08 -04:00
context Refactor: Move login out of models (#16199) 2021-07-24 11:16:34 +01:00
convert Add option to provide signature for a token to verify key ownership (#14054) 2021-07-13 15:28:07 +02:00
cron Refactor: Move login out of models (#16199) 2021-07-24 11:16:34 +01:00
csv Refactor renders (#15175) 2021-04-19 18:25:08 -04:00
doctor Restore creation of git-daemon-export-ok files (#16508) 2021-07-22 12:53:54 +01:00
emoji Run processors on whole of text (#16155) 2021-06-17 11:35:05 +01:00
eventsource Hold the event source when there are no listeners (#15725) 2021-05-15 23:46:13 +02:00
generate Add asymmetric JWT signing (#16010) 2021-06-17 23:56:46 +02:00
git Make cancel from CatFileBatch and CatFileBatchCheck wait for the command to end (#16479) 2021-07-20 20:23:01 +03:00
gitgraph Fix bug on commit graph (#15517) 2021-04-17 10:27:25 +01:00
graceful Support HTTP/2 in Let's Encrypt (#16371) 2021-07-13 18:17:46 +01:00
hcaptcha hCaptcha Support (#12594) 2020-10-02 23:37:53 -04:00
highlight Replace ARCCache with TwoQueueCache to avoid patent issue (#16240) 2021-06-24 14:37:07 -04:00
httpcache Add ETag header (#15370) 2021-04-12 10:49:26 -04:00
httplib Second attempt at preventing zombies (#16326) 2021-07-14 10:43:13 -04:00
indexer Fix data race in bleve indexer (#16474) 2021-07-18 21:59:10 +02:00
lfs Fix various documentation, user-facing, and source comment typos (#16367) 2021-07-08 13:38:13 +02:00
log Fix race in log (#16490) 2021-07-20 20:09:29 +01:00
markup modules/markup/markdown: fix dropped test error (#16438) 2021-07-18 14:09:34 +02:00
matchlist Add Allow-/Block-List for Migrate & Mirrors (#13610) 2020-11-28 19:37:58 -05:00
metrics Prometheus endpoint (#5256) 2018-11-04 22:20:00 -05:00
migrations Fix various documentation, user-facing, and source comment typos (#16367) 2021-07-08 13:38:13 +02:00
nosql Fix setting redis db path (#15698) 2021-05-03 13:24:24 -04:00
notification Fix various documentation, user-facing, and source comment typos (#16367) 2021-07-08 13:38:13 +02:00
options Add StatDir and replace com.StatDir (#14099) 2020-12-22 07:40:57 +08:00
password Fixed assert statements. (#16089) 2021-06-07 07:27:09 +02:00
pprof Add golangci (#6418) 2019-06-12 15:41:28 -04:00
private Second attempt at preventing zombies (#16326) 2021-07-14 10:43:13 -04:00
process Code Formats, Nits & Unused Func/Var deletions (#15286) 2021-04-09 09:40:34 +02:00
public Improve assets handler middleware (#15961) 2021-05-30 18:25:11 +08:00
queue Fix race in log (#16490) 2021-07-20 20:09:29 +01:00
recaptcha Migrate to use jsoniter instead of encoding/json (#14841) 2021-03-01 22:08:10 +01:00
references Fix various documentation, user-facing, and source comment typos (#16367) 2021-07-08 13:38:13 +02:00
repofiles Fix various documentation, user-facing, and source comment typos (#16367) 2021-07-08 13:38:13 +02:00
repository Fix archive error when rename repo or user (#16399) 2021-07-13 14:16:31 +02:00
secret Fix various documentation, user-facing, and source comment typos (#16367) 2021-07-08 13:38:13 +02:00
session Migrate to use jsoniter instead of encoding/json (#14841) 2021-03-01 22:08:10 +01:00
setting Make Mermaid.js limit configurable (#16519) 2021-07-24 00:21:51 -04:00
ssh Second attempt at preventing zombies (#16326) 2021-07-14 10:43:13 -04:00
storage Retry rename on lock induced failures (#16435) 2021-07-15 11:46:07 -04:00
structs Add support for corporate WeChat webhooks (#15910) 2021-07-23 12:41:27 +08:00
svg Fix filepath basename on Windows for SVG bindata (#12241) 2020-07-13 21:16:40 +01:00
sync Fix missing unlock in uniquequeue (#9790) 2020-01-15 23:58:33 +02:00
task Fix various documentation, user-facing, and source comment typos (#16367) 2021-07-08 13:38:13 +02:00
templates Make Mermaid.js limit configurable (#16519) 2021-07-24 00:21:51 -04:00
test Move middlewares to web/middleware (#14480) 2021-01-30 10:55:53 +02:00
timeutil Fix display since time round (#14226) 2021-01-28 13:29:22 +01:00
translation Use index of the supported tags to choose user lang (#15452) 2021-04-14 19:52:01 +01:00
typesniffer Fix various documentation, user-facing, and source comment typos (#16367) 2021-07-08 13:38:13 +02:00
upload Update golangci-lint to version 1.31.0 (#13102) 2020-10-11 21:27:20 +01:00
uri Dump github/gitlab/gitea repository data to a local directory and restore to gitea (#12244) 2020-12-27 11:34:19 +08:00
user Add gitea-vet (#10948) 2020-04-05 07:20:50 +01:00
util Make cancel from CatFileBatch and CatFileBatchCheck wait for the command to end (#16479) 2021-07-20 20:23:01 +03:00
validation Fix various documentation, user-facing, and source comment typos (#16367) 2021-07-08 13:38:13 +02:00
web Restore CORS on git smart http protocol (#16496) 2021-07-21 11:32:35 +08:00