mirror of
https://codeberg.org/forgejo/forgejo.git
synced 2024-11-05 16:59:35 +00:00
c53ad052d8
Some bugs caused by less unit tests in fundamental packages. This PR refactor `setting` package so that create a unit test will be easier than before. - All `LoadFromXXX` files has been splited as two functions, one is `InitProviderFromXXX` and `LoadCommonSettings`. The first functions will only include the code to create or new a ini file. The second function will load common settings. - It also renames all functions in setting from `newXXXService` to `loadXXXSetting` or `loadXXXFrom` to make the function name less confusing. - Move `XORMLog` to `SQLLog` because it's a better name for that. Maybe we should finally move these `loadXXXSetting` into the `XXXInit` function? Any idea? --------- Co-authored-by: 6543 <6543@obermui.de> Co-authored-by: delvh <dev.lh@web.de>
44 lines
772 B
Go
44 lines
772 B
Go
// Copyright 2020 The Gitea Authors. All rights reserved.
|
|
// SPDX-License-Identifier: MIT
|
|
|
|
package setting
|
|
|
|
import (
|
|
"testing"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
ini "gopkg.in/ini.v1"
|
|
)
|
|
|
|
func Test_getCronSettings(t *testing.T) {
|
|
type BaseStruct struct {
|
|
Base bool
|
|
Second string
|
|
}
|
|
|
|
type Extended struct {
|
|
BaseStruct
|
|
Extend bool
|
|
}
|
|
|
|
iniStr := `
|
|
[cron.test]
|
|
Base = true
|
|
Second = white rabbit
|
|
Extend = true
|
|
`
|
|
cfg, err := ini.Load([]byte(iniStr))
|
|
assert.NoError(t, err)
|
|
|
|
extended := &Extended{
|
|
BaseStruct: BaseStruct{
|
|
Second: "queen of hearts",
|
|
},
|
|
}
|
|
|
|
_, err = getCronSettings(cfg, "test", extended)
|
|
assert.NoError(t, err)
|
|
assert.True(t, extended.Base)
|
|
assert.EqualValues(t, extended.Second, "white rabbit")
|
|
assert.True(t, extended.Extend)
|
|
}
|