mirror of
https://codeberg.org/forgejo/forgejo.git
synced 2024-09-21 11:10:11 +00:00
d8bc0495de
Enable [unparam](https://github.com/mvdan/unparam) linter. Often I could not tell the intention why param is unused, so I put `//nolint` for those cases like webhook request creation functions never using `ctx`. --------- Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com> Co-authored-by: delvh <dev.lh@web.de> (cherry picked from commit fc2d75f86d77b022ece848acf2581c14ef21d43b) Conflicts: modules/setting/config_env.go modules/storage/azureblob.go services/webhook/dingtalk.go services/webhook/discord.go services/webhook/feishu.go services/webhook/matrix.go services/webhook/msteams.go services/webhook/packagist.go services/webhook/slack.go services/webhook/telegram.go services/webhook/wechatwork.go run make lint-go and fix Forgejo specific warnings
28 lines
1 KiB
Go
28 lines
1 KiB
Go
// Copyright 2023 The Gitea Authors. All rights reserved.
|
|
// SPDX-License-Identifier: MIT
|
|
|
|
package hash
|
|
|
|
import (
|
|
"strconv"
|
|
|
|
"code.gitea.io/gitea/modules/log"
|
|
)
|
|
|
|
func parseIntParam(value, param, algorithmName, config string, previousErr error) (int, error) {
|
|
parsed, err := strconv.Atoi(value)
|
|
if err != nil {
|
|
log.Error("invalid integer for %s representation in %s hash spec %s", param, algorithmName, config)
|
|
return 0, err
|
|
}
|
|
return parsed, previousErr // <- Keep the previous error as this function should still return an error once everything has been checked if any call failed
|
|
}
|
|
|
|
func parseUIntParam(value, param, algorithmName, config string, previousErr error) (uint64, error) { //nolint:unparam
|
|
parsed, err := strconv.ParseUint(value, 10, 64)
|
|
if err != nil {
|
|
log.Error("invalid integer for %s representation in %s hash spec %s", param, algorithmName, config)
|
|
return 0, err
|
|
}
|
|
return parsed, previousErr // <- Keep the previous error as this function should still return an error once everything has been checked if any call failed
|
|
}
|