forgejo/modules/repository
zeripath 26ef180f46
Correctly rollback in ForkRepository (#17034)
The rollback functionality in
services/repository/repository.go:ForkRepository is incorrect and could
lead to a deadlock as it uses DeleteRepository to delete the rolled-back
repository - a function which creates its own transaction.

This PR adjusts the rollback function to only use RemoveAll as any
database changes will be automatically rolled-back. It also handles
panics and adjusts the Close within WithTx to ensure that if there is a
panic the session will always be closed.

Signed-off-by: Andrew Thornton <art27@cantab.net>
2021-09-14 18:16:40 +02:00
..
adopt.go Fix various documentation, user-facing, and source comment typos (#16367) 2021-07-08 13:38:13 +02:00
archive.go Fix archive error when rename repo or user (#16399) 2021-07-13 14:16:31 +02:00
branch.go [API] Add pagination to ListBranches (#14524) 2021-02-03 20:06:13 +01:00
cache.go Make commit info cancelable (#16032) 2021-06-06 19:44:58 -04:00
check.go Update repository size on cron gc task (#15177) 2021-03-28 05:56:28 +02:00
commits.go Report the correct number of pushes on the feeds (#16811) 2021-08-25 19:04:58 -04:00
commits_test.go Replace list.List with slices (#16311) 2021-08-09 14:08:51 -04:00
create.go Check if label template exist first (#14384) 2021-01-18 21:00:50 +01:00
create_test.go Fixed assert statements. (#16089) 2021-06-07 07:27:09 +02:00
fork.go Correctly rollback in ForkRepository (#17034) 2021-09-14 18:16:40 +02:00
fork_test.go Refactor the fork service slightly to take ForkRepoOptions (#16744) 2021-08-28 16:37:14 +08:00
generate.go Ensure that HEAD is updated to match default branch in template generation (#13948) 2020-12-11 22:41:59 +01:00
hooks.go Add agit flow support in gitea (#14295) 2021-07-28 17:42:56 +08:00
init.go [API] Add pagination to ListBranches (#14524) 2021-02-03 20:06:13 +01:00
main_test.go Move push commits from models to modules/repository (#9370) 2020-01-10 17:34:21 +08:00
push.go Fix a bug on refactoring (#13373) 2020-10-31 23:42:54 +08:00
repo.go Add skip and limit to git.GetTags (#16897) 2021-09-10 19:30:37 +02:00
update.go Move PushUpdateAddDeleteTags to repository module from models (#10106) 2020-02-03 09:47:04 +01:00